Skip to content

Commit

Permalink
feat: remove mail header 'Content-Transfer-Encoding: binary'
Browse files Browse the repository at this point in the history
The header gets converted to 'Content-Transfer-Encoding: quoted-printable' causing 'arc=fail (body hash mismatch)' with gmail
  • Loading branch information
sanderhollaar committed Aug 22, 2023
1 parent 0fc695b commit 3679771
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
8 changes: 6 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

### Changed
- Remove mail header 'Content-Transfer-Encoding: binary'
The header gets converted to 'Content-Transfer-Encoding: quoted-printable' causing 'arc=fail (body hash mismatch)' with gmail

## [0.13.1] - 2023-08-16
### Fixed
- Invalid amount of arguments in query scan when e-mail revalidation is disabled
Expand All @@ -27,14 +31,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

As part of e-mail address revalidation:
- `VerifyMXRecord` incorporates a check to see if there is an active network connection
- MyIrma server: `/user` returns an additional field `revalidate_in_progress` in the JSON response body, indicating whether the e-mail address is being revalidated or not
- MyIrma server: `/user` returns an additional field `revalidate_in_progress` in the JSON response body, indicating whether the e-mail address is being revalidated or not
- MyIrma server: `/user/delete` and `/email/remove` return a 500 status code and `REVALIDATE_EMAIL` error type if one or more e-mail addresses of the user are invalid

**Note:** Enabling e-mail address revalidation requires a change in the database schema. In order to do this please add the `revalidate_on` column of type `bigint` to the `irma.emails` table. See the [schema](https://github.com/privacybydesign/irmago/tree/master/server/keyshare/schema.sql#L50) file. Otherwise e-mail address revalidation is disabled and there will not be a breaking change.

### Fixed
- Race conditions in database logic of revocation storage
- `irma scheme verify` not detecting missing files in index
- `irma scheme verify` not detecting missing files in index
- Scheme verification/signing does not reject credentials with invalid revocation settings
- Write transactions within memory implementation of revocation storage may lead to unintended changes

Expand Down
1 change: 0 additions & 1 deletion server/keyshare/email.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ func (conf EmailConfiguration) SendEmail(
fmt.Fprintf(&message, "From: %s\r\n", from.Address)
fmt.Fprintf(&message, "Subject: %s\r\n", conf.TranslateString(subjects, lang))
fmt.Fprintf(&message, "Content-Type: text/html; charset=UTF-8\r\n")
fmt.Fprintf(&message, "Content-Transfer-Encoding: binary\r\n")
fmt.Fprintf(&message, "\r\n")
fmt.Fprint(&message, content.String())

Expand Down

0 comments on commit 3679771

Please sign in to comment.