Bounce tracking: Record user activation times. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is my first time trying to write a monkey patch spec. In this case I don't think it matters when the steps are executed relative to what is already there, so I just said to "append" these steps. Open to suggestions, though. |
jyasskin
reviewed
Mar 29, 2023
wanderview
force-pushed
the
dev-interaction
branch
2 times, most recently
from
646d12c to
303fb48
Compare
|
I've addressed action items and also fixed a few mistakes I made. In particular I realized we are using schemeless site comparisons because cookies are shared across schemes by default. @jyasskin PTAL. Thanks. |
wanderview
force-pushed
the
dev-interaction
branch
2 times, most recently
from
2f60726 to
557662b
Compare
jyasskin
approved these changes
Mar 30, 2023
jyasskin
reviewed
Mar 31, 2023
This information will be used as a signal in other algorithms to avoid deleting storage for these sites. The deletion algorithms have not been written yet.
wanderview
force-pushed
the
dev-interaction
branch
from
557662b to
cf235ab
Compare
github-actions bot
added a commit
that referenced
this pull request
Apr 4, 2023
SHA: 56f0d14 Reason: push, by wanderview Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This information will be used as a signal in other algorithms to avoid deleting storage for these sites. The deletion algorithms have not been written yet.
Preview | Diff