Fix missing permissions ref and var warnings #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johannhof for review note: the |
johannhof
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
We shouldn't use the permissions task source, see privacycg/storage-access#144, which requires some follow-up work. So, please file an issue similar to the SAA one before merging this (and ideally add an inline issue to the spec) :)
Also correct CORS header links
|
filed an issue and referenced it inline. (Also fixed a couple of http header refs I had missed. Confirmed no errors or warnings both via the bikeshed web interface and the command line). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that there are no behavioral changes associated with this PR.
Preview | Diff