Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Extend Hardware Section #989

Open
wants to merge 50 commits into
base: master
Choose a base branch
from
Open

Conversation

ghbjklhv
Copy link
Contributor

@ghbjklhv ghbjklhv commented Jun 15, 2019

Description: Add Extended Hardware Section based on #616 and #904
What was changed: I recommend looking through the preview:
https://deploy-preview-989--privacytools-io.netlify.com/classic/#laptops
Why isn't ___ blank listed?: Only privacy and free software supporting projects are listed.
Basically all recommendations have had to some degree of audit. If you think I skipped something feel free to recommend changes in the comments!

Edits from maintainers are welcome!

@netlify
Copy link

netlify bot commented Jun 15, 2019

Deploy preview for privacytools-io ready!

Built with commit 9f55209

https://deploy-preview-989--privacytools-io.netlify.com

@Mikaela Mikaela requested review from jonaharagon, Vincevrp, blacklight447, privacytoolsIO and a team and removed request for jonaharagon June 16, 2019 09:00
_includes/sections/key-manager.html Outdated Show resolved Hide resolved
@jonaharagon
Copy link
Contributor

jonaharagon commented Jun 24, 2019

@ghbjklhv do you not test your changes locally with bundle exec jekyll serve before pushing? lol

I'll take a look at these changes in a bit.

Edit: Oh I see you're making these changes on GitHub.com, that seems rather tedious 😝

@ghbjklhv
Copy link
Contributor Author

ghbjklhv commented Jun 24, 2019

@jonaharagon Yeah, I use the online editor now.

My computer always shows errors when compiling:

Configuration file: /home/usr/Jekyll1/privacytools.io-patch-6/_config.yml
       Deprecation: The 'plugins' configurationoption has been renamed to 'plugins_dir'. Please update your config file accordingly.
Configuration file: /home/usr/Jekyll1/privacytools.io-patch-6/_config.yml
       Deprecation: The 'plugins' configurationoption has been renamed to 'plugins_dir'. Please update your config file accordingly.
Configuration file: /home/usr/Jekyll1/privacytools.io-patch-6/_config.yml
       Deprecation: The 'plugins' configurationoption has been renamed to 'plugins_dir'. Please update your config file accordingly.
jekyll 3.1.6 | Error:  undefined method `config=' for #<Jekyll::Site:0x0055d37d225668>
Did you mean?  config

Sorry if my PR seems a bit messy. :P

I'll see if I can fix my Jekyll.....

@WorryTheBirds12
Copy link

WorryTheBirds12 commented Jul 30, 2019

@jonaharagon Are ya'll just waiting for #904 to clear up.
Or is something wrong with this post.

Hasn't been reviewed in over a month.

Copy link
Contributor

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this PR. I just need the SeaBIOS image fixed and then I'll approve this.

Long-term I also want to stop using card.html entirely on the site so we should switch everything to cardv2.html, but if you don't want to do that now we can make that change later and I'll merge this in the meantime.


{% include card.html color="primary"
title="SeaBIOS"
image="/assets/img/tools/seabios.png"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image seems to be broken?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Seabios doesn't seem to have a logo.
If it is required, they have a Wiki logo: https://www.coreboot.org/images/a/ae/Chip_tools.png


Github blocked my old account but edits from maintainers should be turned on.
Or, you can add if after merging.

@ghbjklhv1
Copy link

ghbjklhv1 commented Oct 12, 2019

Would it be possible for you to start a discussion thread for some of these on the forum?
Some of the products like the Librem 5 and EOMA68 have new status updates.[1][2]


@jonaharagon @Mikaela

@Mikaela
Copy link
Contributor

Mikaela commented Oct 12, 2019

Hardware is not my cup of tea, so I prefer to not get involved with this PR.

@privacytoolsIO/editorial please see the previous comment.

@jonaharagon jonaharagon mentioned this pull request Feb 17, 2020
4 tasks
@ghbjklhv ghbjklhv requested a review from a team as a code owner June 24, 2022 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants