-
-
Notifications
You must be signed in to change notification settings - Fork 384
Extend Hardware Section #989
base: master
Are you sure you want to change the base?
Conversation
Deploy preview for privacytools-io ready! Built with commit 9f55209 |
@ghbjklhv do you not test your changes locally with I'll take a look at these changes in a bit. Edit: Oh I see you're making these changes on GitHub.com, that seems rather tedious 😝 |
@jonaharagon Yeah, I use the online editor now. My computer always shows errors when compiling:
Sorry if my PR seems a bit messy. :P I'll see if I can fix my Jekyll..... |
@jonaharagon Are ya'll just waiting for #904 to clear up. Hasn't been reviewed in over a month. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this PR. I just need the SeaBIOS image fixed and then I'll approve this.
Long-term I also want to stop using card.html
entirely on the site so we should switch everything to cardv2.html
, but if you don't want to do that now we can make that change later and I'll merge this in the meantime.
|
||
{% include card.html color="primary" | ||
title="SeaBIOS" | ||
image="/assets/img/tools/seabios.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image seems to be broken?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Seabios doesn't seem to have a logo.
If it is required, they have a Wiki logo: https://www.coreboot.org/images/a/ae/Chip_tools.png
Github blocked my old account but edits from maintainers should be turned on.
Or, you can add if after merging.
Hardware is not my cup of tea, so I prefer to not get involved with this PR. @privacytoolsIO/editorial please see the previous comment. |
Description: Add Extended Hardware Section based on #616 and #904
What was changed: I recommend looking through the preview:
https://deploy-preview-989--privacytools-io.netlify.com/classic/#laptops
Why isn't ___ blank listed?: Only privacy and free software supporting projects are listed.
Basically all recommendations have had to some degree of audit. If you think I skipped something feel free to recommend changes in the comments!
Edits from maintainers are welcome!