-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mod : Estimation du prix de craft #163
base: master
Are you sure you want to change the base?
Conversation
Je ves rajouter tout les inputs du jeu pour avoir un focus directement
Crédit : Tird, Reyem, Prout01, Aejii, Romarin
Crédit : Reyem, Aejii, Tird, Prout01, Romarin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le mod est sympa, je te suggère quand même quelques modifications.
- Esthétique (kamas)
- Technique pour le prochain gars (ou toi) qui devra regarder/modifier le code un jour
let leftdiv = document.createElement("div"); | ||
leftdiv.className = "estimationprix"; | ||
leftdiv.id = "eprix"; | ||
leftdiv.innerText = "Prix moyen du craft : " + this.formatNumber(totalprix) + " Kamas" + " (" + totalpods + " Pods)."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il serait peut-être + judicieux d'afficher l'icône Kamas, plutôt que le mot.
Tu peux faire quelque chose comme ça par exemple (à tester):
leftdiv.innerText = "Prix moyen du craft : " + this.formatNumber(totalprix) + " <img src='./assets/ui/icons/kamas.png' width='20px' height='16px' />" + " (" + totalpods + " Pods).";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je vien de reupload le script, il faudra juste que tu jete un coup d'oeil niveau css pour mettre les 3 div sur la meme ligne stp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ta solution me semble étrange, je regarde ça ce week-end ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
En fait il faut simplement faire un .innerHTML
plutôt qu'un .innerText
Il faudra juste que Broseidon jete un coup d'oeil niveau CSS
Merci Broseidon
Aucun probleme contastater, pret a etre merge pour une beta |
Changement du nom de classe pour avoir le mod depuis le menu des métier
No description provided.