Skip to content

Commit

Permalink
replace kwargs by actual arguments
Browse files Browse the repository at this point in the history
  • Loading branch information
auguste-probabl committed Mar 3, 2025
1 parent ef04472 commit 414ef12
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions skore/src/skore/sklearn/_estimator/feature_importance_accessor.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import joblib
import numpy as np
import pandas as pd
from numpy.random import RandomState
from numpy.typing import ArrayLike
from sklearn.base import is_classifier
from sklearn.inspection import permutation_importance
Expand Down Expand Up @@ -112,7 +113,11 @@ def feature_permutation(
X: Optional[ArrayLike] = None,
y: Optional[ArrayLike] = None,
scoring: Optional[Scoring] = None,
**kwargs,
n_repeats: int = 5,
n_jobs: Optional[int] = None,
random_state: Optional[Union[int, RandomState]] = None,
sample_weight: Optional[ArrayLike] = None, # Sample weights used in scoring.
max_samples: float = 1.0,
) -> pd.DataFrame:
"""Report the permutation feature importance.
Expand Down Expand Up @@ -184,7 +189,11 @@ def feature_permutation(
X=X,
y=y,
scoring=scoring,
**kwargs,
n_repeats=n_repeats,
n_jobs=n_jobs,
random_state=random_state,
sample_weight=sample_weight,
max_samples=max_samples,
)

def _feature_permutation(
Expand Down

0 comments on commit 414ef12

Please sign in to comment.