-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Change config_context docs #1345
Conversation
Coverage Report for backend
|
Correct, it allows you to temporarily override the global config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me!
Actually global would refer to set a variable for the main process and dispatch the same config to sub process or thread. Local is wrong in this case because it would refer to thread local meaning that you might expect the configuration to work in locally for the main process and not being dispatched to other threads that are started afterword. I understand that there is confusion here about the term. So we should probably be more explicit in the long summary to remove any ambiguity. |
I'll open a new PR trying to have both the Python details and DS language in there. |
From the example given in config_context, I understand that it is not global, as apposed to set_config, but rather a local behavior. Is it correct?
In any case, the current docs is blurry to me, because it doesn't appear at first sight what is the difference between
set_config
andconfig_context
.