Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repr): Give a description to attributes #1366

Merged
merged 14 commits into from
Mar 7, 2025

Conversation

MarieSacksick
Copy link
Contributor

Closes #1235

I had to go through regex because from what I understand from inspect, there is no way to access the documentation of an attribute. There is very little risk that the regex matches something before the attribute description because of naming overlap. If we think that this risk is to big, as there is no way to do a test, we should close #1235 as not possible.

What it does for an EstimatorReport:
image

What it does for a CrossValidationReport:
image

What it does for a ComparisonReport:
image

Copy link
Contributor

github-actions bot commented Feb 26, 2025

Coverage

Coverage Report for backend
FileStmtsMissCoverMissing
venv/lib/python3.12/site-packages/skore
   __init__.py150100% 
   _config.py280100% 
   exceptions.py440%4–23
venv/lib/python3.12/site-packages/skore/persistence
   __init__.py00100% 
venv/lib/python3.12/site-packages/skore/persistence/item
   __init__.py55198%97
   altair_chart_item.py19191%14
   item.py22195%86
   matplotlib_figure_item.py36195%19
   media_item.py220100% 
   numpy_array_item.py27194%16
   pandas_dataframe_item.py29194%14
   pandas_series_item.py29194%14
   pickle_item.py220100% 
   pillow_image_item.py25193%15
   plotly_figure_item.py20192%14
   polars_dataframe_item.py27194%14
   polars_series_item.py22192%14
   primitive_item.py23291%13–15
   sklearn_base_estimator_item.py29194%15
venv/lib/python3.12/site-packages/skore/persistence/repository
   __init__.py20100% 
   item_repository.py59591%15–16, 202–203, 226
venv/lib/python3.12/site-packages/skore/persistence/storage
   __init__.py40100% 
   abstract_storage.py220100% 
   disk_cache_storage.py33195%44
   in_memory_storage.py200100% 
venv/lib/python3.12/site-packages/skore/project
   __init__.py20100% 
   project.py81199%283
venv/lib/python3.12/site-packages/skore/sklearn
   __init__.py60100% 
   _base.py1701492%44, 57, 125, 128, 181–190, 202–>208, 223, 226–227
   find_ml_task.py61099%136–>144
   types.py13285%33, 61
venv/lib/python3.12/site-packages/skore/sklearn/_comparison
   __init__.py50100% 
   metrics_accessor.py164297%165, 166–>168, 1218
   precision_recall_curve_display.py73197%196–>199, 304
   prediction_error_display.py671078%97, 154–>exit, 209, 214–218, 227, 231, 236–238
   report.py64196%16, 251–>254
   roc_curve_display.py69196%204–>213, 213–>216, 308
venv/lib/python3.12/site-packages/skore/sklearn/_cross_validation
   __init__.py50100% 
   metrics_accessor.py170099%142–>144, 144–>146
   report.py105198%22
venv/lib/python3.12/site-packages/skore/sklearn/_estimator
   __init__.py70100% 
   feature_importance_accessor.py390100% 
   metrics_accessor.py3251195%166–175, 203–>212, 211, 241, 252–>254, 282, 309–313, 328, 351, 363, 364–>366
   report.py127197%22, 229–>235, 237–>239
venv/lib/python3.12/site-packages/skore/sklearn/_plot
   __init__.py40100% 
   precision_recall_curve.py129198%240–>257, 329
   prediction_error.py102198%173, 189–>192
   roc_curve.py1430100% 
   style.py140100% 
   utils.py99594%31, 55–57, 61
venv/lib/python3.12/site-packages/skore/sklearn/train_test_split
   __init__.py00100% 
   train_test_split.py36294%16–17
venv/lib/python3.12/site-packages/skore/sklearn/train_test_split/warning
   __init__.py80100% 
   high_class_imbalance_too_few_examples_warning.py17190%79
   high_class_imbalance_warning.py180100% 
   random_state_unset_warning.py12188%15
   shuffle_true_warning.py10183%46
   stratify_is_set_warning.py12188%15
   time_based_column_warning.py23286%17, 73
   train_test_split_warning.py5180%21
venv/lib/python3.12/site-packages/skore/utils
   __init__.py60100% 
   _accessor.py170100% 
   _environment.py27270%1–51
   _index.py50100% 
   _logger.py22220%3–38
   _parallel.py38388%23–33, 124
   _patch.py13553%21–37
   _progress_bar.py340100% 
   _show_versions.py33295%65–66
TOTAL297414494% 

Tests Skipped Failures Errors Time
635 3 💤 0 ❌ 0 🔥 54.161s ⏱️

Copy link
Contributor

github-actions bot commented Feb 26, 2025

Documentation preview @ b198cdb

Copy link
Contributor

@auguste-probabl auguste-probabl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me in principle!

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would request a test in the different reporter to at least on one attribute just to catch potential regression in the future.

auguste-probabl
auguste-probabl previously approved these changes Mar 6, 2025
Copy link
Contributor

@auguste-probabl auguste-probabl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@auguste-probabl auguste-probabl merged commit 8cab80d into main Mar 7, 2025
19 checks passed
@auguste-probabl auguste-probabl deleted the 1235_description_in_cv_report branch March 7, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Give more description in the CrossValidationReport to access a fold
3 participants