-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(repr): Give a description to attributes #1366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me in principle!
Co-authored-by: Auguste Baum <[email protected]>
Co-authored-by: Auguste Baum <[email protected]>
Co-authored-by: Auguste Baum <[email protected]>
Co-authored-by: Auguste Baum <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would request a test in the different reporter to at least on one attribute just to catch potential regression in the future.
Co-authored-by: Auguste Baum <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Closes #1235
I had to go through regex because from what I understand from inspect, there is no way to access the documentation of an attribute. There is very little risk that the regex matches something before the attribute description because of naming overlap. If we think that this risk is to big, as there is no way to do a test, we should close #1235 as not possible.
What it does for an EstimatorReport:

What it does for a CrossValidationReport:

What it does for a ComparisonReport:
