chore: add a prepare step so that git dependencies build #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is convenient to be able to specify dependencies in package.json
which point to particular git commits. One use case is allowing
dependencies on PRs which are not yet merged and published to npm.org,
such as
probil#1
in order to obtain functioning ESM support.
In theory this should be achievable via:
"vitest-chrome": "probil/vitest-chrome#5fb1634b"
https://docs.npmjs.com/cli/v8/configuring-npm/package-json#git-urls-as-dependencies
states:
> When installing from a git repository, the presence of certain fields
> in the package.json will cause npm to believe it needs to perform a
> build. To do so your repository will be cloned into a temporary
> directory, all of its deps installed, relevant scripts run, and the
> resulting directory packed and installed.
>
> This flow will occur if your git dependency uses workspaces, or if
> any of the following scripts are present:
>
> - `build`
> - `prepare`
> - `prepack`
> - `preinstall`
> - `install`
> - `postinstall`
However it seems that, at least with pnpm, the presence of a `build`
step is not sufficient.
So add a `prepare` step which just dispatches to the `build` step.
This makes vitest-chrome installable via a git dependency.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is convenient to be able to specify dependencies in package.json which point to particular git commits. One use case is allowing dependencies on PRs which are not yet merged and published to npm.org, such as
in order to obtain functioning ESM support.
In theory this should be achievable via:
https://docs.npmjs.com/cli/v8/configuring-npm/package-json#git-urls-as-dependencies
states:
However it seems that, at least with pnpm, the presence of a
buildstep is not sufficient.So add a
preparestep which just dispatches to thebuildstep. This makes vitest-chrome installable via a git dependency.See also the backport: extend-chrome#37