Delete unnecessary return new Promise in Redux actions.

[lindapaiste]

Changes:

• Remove all unnecessary new Promise constructors from Redux actions.

We have a lot of instances where we a wrapping an API call in return new Promise((resolve, reject) => {. This is unnecessary because the API call is already a Promise.

This code:

return new Promise((resolve) => {
  someFunction(args)
    .then((response) => {
      /** ... **/
      resolve();
    })
    .catch((error) => {
      /** ... **/
      resolve({ error });
    });
});

Is the same as this:

return someFunction(args)
  .then((response) => {
    /** ... **/
  })
  .catch((error) => {
    /** ... **/
    return { error };
  });

Both return a Promise which either resolves to void (on success) or resolves to an object with an error property (on failure).

There's a lot more cleanup that can be done here in the future, but right now I'm just changing this one thing. Notes for the future.

• We often resolve to { error } but we don't use this value anywhere.
  -I've encountered uncaught errors which are thrown in the catch clauses. We are assuming that the error variable always has a property error.response.data and this is not always the case, as the catch clause catches ALL errors. (This won't crash the app but it logs to the console).
• Some async action creator functions return the Promise and others don't.

This returns a Promise:

return (dispatch) =>
  apiClient
    .get('path')

This returns void:

return (dispatch) => {
  apiClient
    .get('path')
};

I have verified that this pull request:

• has no linting errors (npm run lint)
• has no test errors (npm run test)
• is from a uniquely-named feature branch and is up to date with the develop branch.
• is descriptively named and links to an issue number, i.e. Fixes #123

[PiyushChandra17]

I think return is missing, otherwise all the refactor looks good to me. Nicely done.

[PiyushChandra17]

I think return is missing here, otherwise all the changes looks good to me. Nicely Done.