Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Legacy CollectionListRowBase code to Functional component #2410

Closed

Conversation

KSSaiTeja
Copy link

@KSSaiTeja KSSaiTeja commented Sep 11, 2023

Fixes: #2358
closes: #2358

Changes: i have changed collectionListRow legacy code to Functional component and also ran all tests. This is my first PR on this organisation... Hope this will merge and that will give me more inspiration to do

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Sep 11, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@KSSaiTeja
Copy link
Author

@lindapaiste please review my PR and let me know id there are any changes.. :D

@KSSaiTeja
Copy link
Author

@lindapaiste please review my pending PR's 🙂

@KSSaiTeja
Copy link
Author

@lindapaiste may i know the reason for not merging my PR

@KSSaiTeja
Copy link
Author

@lindapaiste Please tell me why PR is still pending..

@lindapaiste
Copy link
Collaborator

@KSSaiTeja we have been inundated with PRs this past week and I can’t keep up! Please be patient, I will get to it eventually.

@KSSaiTeja
Copy link
Author

@lindapaiste i fixed the bugs you've mentioned. please review my PR

@lindapaiste
Copy link
Collaborator

I am closing this PR in favor of #2415 which has fewer issues. Specifically, this PR crashes due to the mistake on these lines. The default export from the formatDate file is an object and not a function.

import formatDate from '../../../../utils/formatDate';

<td>{formatDate(collection.createdAt)}</td>
<td>{formatDate(collection.updatedAt)}</td>

This mistake is immediately apparent when navigating to the collections page as the entire app crashes. In the future, please make sure that you have reviewed your own work and verified that the code runs correctly before submitting a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert legacy React class components to function components
2 participants