-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Legacy CollectionListRowBase code to Functional component #2410
Conversation
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
@lindapaiste please review my PR and let me know id there are any changes.. :D |
@lindapaiste please review my pending PR's 🙂 |
@lindapaiste may i know the reason for not merging my PR |
@lindapaiste Please tell me why PR is still pending.. |
@KSSaiTeja we have been inundated with PRs this past week and I can’t keep up! Please be patient, I will get to it eventually. |
client/modules/IDE/components/CollectionList/CollectionListRow.jsx
Outdated
Show resolved
Hide resolved
@lindapaiste i fixed the bugs you've mentioned. please review my PR |
I am closing this PR in favor of #2415 which has fewer issues. Specifically, this PR crashes due to the mistake on these lines. The default export from the p5.js-web-editor/client/modules/IDE/components/CollectionList/CollectionListRow.jsx Line 11 in c285560
p5.js-web-editor/client/modules/IDE/components/CollectionList/CollectionListRow.jsx Lines 199 to 200 in c285560
This mistake is immediately apparent when navigating to the collections page as the entire app crashes. In the future, please make sure that you have reviewed your own work and verified that the code runs correctly before submitting a PR. |
Fixes: #2358
closes: #2358
Changes: i have changed
collectionListRow
legacy code toFunctional component
and also ran all tests. This is my first PR on this organisation... Hope this will merge and that will give me more inspiration to doI have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123