Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Search bar to be a functional component #2453

Conversation

souvikrajsingh
Copy link

Fixes #issue-number

Changes:

Ref #2358

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Sep 18, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@raclim
Copy link
Collaborator

raclim commented Jun 13, 2024

Thanks for your work on this! Overall I think this looks good, but some ideally we'd like to destructure the props that are being passed to this component. Due to several other PRs we have for this issue, I'm going to close this one for now. I'm sorry we couldn't get this in, but please feel free to check out our other issues!

@raclim raclim closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants