[p5.js 2.0] Refactor MatrixNumJs to new generic Matrix API #7522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6765
@limzykenneth @davepagurek: Please review my changes.
Changes:
This PR updates the
MatrixNumJs
implementation to match the latestMatrix
API interface, the most noticeable changes are the following:mat3
andmat4
definitions for a genericmatrix
andsqDimention
to keep track of a single generic square matrix.mat3
andmat4
so its still accessible to all the existing calls in the library.invert
,transpose
androtate
to match the genericMatrix
API.Matrix.set
method.gl
implementation is much faster than the NumJsSince the NumJs implementation I understand is still in testing process wanted to ask if we should merge the numjs package.json dependency, or should this be kept in another branch? I have updated the package and lock files to make sure everything works, but please let me know what you think would be best. Thanks
Analysis
PR Checklist
npm run lint
passes