Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anmd fix for pca input #2022

Merged
merged 1 commit into from
Dec 27, 2024
Merged

anmd fix for pca input #2022

merged 1 commit into from
Dec 27, 2024

Conversation

jamesmkrieger
Copy link
Contributor

PCA has variances as eigvals, so we need to take the reciprocal to get equivalent eigvals for scaling.

anupam-banerjee
anupam-banerjee approved these changes Dec 27, 2024
View reviewed changes
Copy link

@anupam-banerjee anupam-banerjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jamesmkrieger
Copy link
Contributor Author

Thanks

@jamesmkrieger jamesmkrieger merged commit e0df1f1 into prody:main Dec 27, 2024
5 checks passed
@jamesmkrieger jamesmkrieger deleted the anmd branch December 27, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anupam-banerjee anupam-banerjee anupam-banerjee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesmkrieger @anupam-banerjee