[HVAC] Implement TC-TSTAT-2.2 #36023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
github-actions
bot
added
app
tests
matter-1.4-te2-script-change
|
PR #36023: Size comparison from 6a29ee5 to 83be40a Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
fessehaeve
reviewed
Oct 14, 2024
fessehaeve
reviewed
Oct 14, 2024
Co-authored-by: fesseha-eve <[email protected]>
bauerschwan
approved these changes
Oct 23, 2024
bauerschwan
reviewed
Oct 23, 2024
|
@hasty We have to add steps 19 to 22c as per the test plan. Here is the test plan reference: https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/cluster/thermostat.adoc#tc-tstat-2-2-setpoint-test-cases-with-server-as-dut |
KishokG
reviewed
Jan 31, 2025
|
The following PR: hasty#3 needs to be merged into Hasty's branch else the changes needs to be updated manually in this PR. @cjandhyala FYI |
fixed below mentioned discrepancies on the code: Step-3c: The test plan expects a Success response, but the script is checking for a ConstraintError. If the value does not violate any conditions, the response should be Success. In such cases, the test will fail. Step-4c: If the AUTO feature is enabled, the script writes the UnoccupiedCoolingSetpoint attribute with MaxCoolSetpointLimitValue and checks for a ConstraintError response, which is not required. Step-5c: The script should check the following condition when the AUTO feature is enabled: Min(MaxHeatSetpointLimit, (UnoccupiedCoolingSetpoint - MinSetpointDeadBand)). However, this condition is missing in the script, and it incorrectly checks for a ConstraintError response. Step-7a: The write and read verification is missing. Step-9b: The script incorrectly writes the attribute value using AbsMinCoolSetpointLimitValue instead of MinCoolSetpointLimitValue. Step-9c: A duplicate read check has been removed.
Update TC_TSTAT_2_2.py
|
PR #36023: Size comparison from 35781e5 to 1964b95 Full report (3 builds for cc32xx, stm32)
|
nivi-apple
reviewed
Feb 6, 2025
nivi-apple
approved these changes
Feb 6, 2025
|
PR #36023: Size comparison from 93114c7 to 5b66a65 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36023: Size comparison from 841df09 to 5862800 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36023: Size comparison from 841df09 to c3528c4 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
pushed a commit
to cecille/connectedhomeip
that referenced
this pull request
Feb 11, 2025
* Initial generated test * Fixed and compared against test plan * Remove unused TC-TSTAT-2.2 yaml * Apply suggestions from code review Co-authored-by: fesseha-eve <[email protected]> * Update TC_TSTAT_2_2.py fixed below mentioned discrepancies on the code: Step-3c: The test plan expects a Success response, but the script is checking for a ConstraintError. If the value does not violate any conditions, the response should be Success. In such cases, the test will fail. Step-4c: If the AUTO feature is enabled, the script writes the UnoccupiedCoolingSetpoint attribute with MaxCoolSetpointLimitValue and checks for a ConstraintError response, which is not required. Step-5c: The script should check the following condition when the AUTO feature is enabled: Min(MaxHeatSetpointLimit, (UnoccupiedCoolingSetpoint - MinSetpointDeadBand)). However, this condition is missing in the script, and it incorrectly checks for a ConstraintError response. Step-7a: The write and read verification is missing. Step-9b: The script incorrectly writes the attribute value using AbsMinCoolSetpointLimitValue instead of MinCoolSetpointLimitValue. Step-9c: A duplicate read check has been removed. * Python linter fix for TC_TSTAT_2_2 * Update src/python_testing/TC_TSTAT_2_2.py Co-authored-by: Nivi Sarkar <[email protected]> * Restore setpoints to original values at end of test * Use get_endpoint method to find active endpoint * Update CI Test Arguments to the apparent new style --------- Co-authored-by: fesseha-eve <[email protected]> Co-authored-by: Kishok G <[email protected]> Co-authored-by: Nivi Sarkar <[email protected]>
andy31415
pushed a commit
that referenced
this pull request
Feb 11, 2025
* Initial generated test * Fixed and compared against test plan * Remove unused TC-TSTAT-2.2 yaml * Apply suggestions from code review * Update TC_TSTAT_2_2.py fixed below mentioned discrepancies on the code: Step-3c: The test plan expects a Success response, but the script is checking for a ConstraintError. If the value does not violate any conditions, the response should be Success. In such cases, the test will fail. Step-4c: If the AUTO feature is enabled, the script writes the UnoccupiedCoolingSetpoint attribute with MaxCoolSetpointLimitValue and checks for a ConstraintError response, which is not required. Step-5c: The script should check the following condition when the AUTO feature is enabled: Min(MaxHeatSetpointLimit, (UnoccupiedCoolingSetpoint - MinSetpointDeadBand)). However, this condition is missing in the script, and it incorrectly checks for a ConstraintError response. Step-7a: The write and read verification is missing. Step-9b: The script incorrectly writes the attribute value using AbsMinCoolSetpointLimitValue instead of MinCoolSetpointLimitValue. Step-9c: A duplicate read check has been removed. * Python linter fix for TC_TSTAT_2_2 * Update src/python_testing/TC_TSTAT_2_2.py * Restore setpoints to original values at end of test * Use get_endpoint method to find active endpoint * Update CI Test Arguments to the apparent new style --------- Co-authored-by: Hasty Granbery <[email protected]> Co-authored-by: fesseha-eve <[email protected]> Co-authored-by: Kishok G <[email protected]> Co-authored-by: Nivi Sarkar <[email protected]>
pimpalemahesh
pushed a commit
to pimpalemahesh/connectedhomeip
that referenced
this pull request
Feb 12, 2025
* Initial generated test * Fixed and compared against test plan * Remove unused TC-TSTAT-2.2 yaml * Apply suggestions from code review Co-authored-by: fesseha-eve <[email protected]> * Update TC_TSTAT_2_2.py fixed below mentioned discrepancies on the code: Step-3c: The test plan expects a Success response, but the script is checking for a ConstraintError. If the value does not violate any conditions, the response should be Success. In such cases, the test will fail. Step-4c: If the AUTO feature is enabled, the script writes the UnoccupiedCoolingSetpoint attribute with MaxCoolSetpointLimitValue and checks for a ConstraintError response, which is not required. Step-5c: The script should check the following condition when the AUTO feature is enabled: Min(MaxHeatSetpointLimit, (UnoccupiedCoolingSetpoint - MinSetpointDeadBand)). However, this condition is missing in the script, and it incorrectly checks for a ConstraintError response. Step-7a: The write and read verification is missing. Step-9b: The script incorrectly writes the attribute value using AbsMinCoolSetpointLimitValue instead of MinCoolSetpointLimitValue. Step-9c: A duplicate read check has been removed. * Python linter fix for TC_TSTAT_2_2 * Update src/python_testing/TC_TSTAT_2_2.py Co-authored-by: Nivi Sarkar <[email protected]> * Restore setpoints to original values at end of test * Use get_endpoint method to find active endpoint * Update CI Test Arguments to the apparent new style --------- Co-authored-by: fesseha-eve <[email protected]> Co-authored-by: Kishok G <[email protected]> Co-authored-by: Nivi Sarkar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a Python implementation of TC-TSTAT-2.2 to replace the unused TC-TSTAT-2.2 YAML test.
Fixes #35748
Testing
This should restore the setpoint values after the test, allowing for multiple runs.