-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM XMLs: 1.5 0.7 ballot #37329
base: master
Are you sure you want to change the base?
DM XMLs: 1.5 0.7 ballot #37329
Conversation
Note that this contains a significant number of changes in one commit, and I apologise for that, but the new spec cannot be scraped with the DM editor, so I needed to swap to alchemy to get the new spec scraped. Hence this contains both the alchemy formatting changes (as outlined in project-chip#37201 as well as the changes from the last ballot to the current ballot.
This happens on ID-TBD in the ballot.
PR #37329: Size comparison from 3044eeb to 97b28e2 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on faith.
508 Second Street, Suite 206 | ||
Davis, CA 95616, USA | ||
|
||
:xrefstyle: basic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure - comes from alchemy. I don't think it does anything. @hasty - is this here for a reason or did it just sneak in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not review all of the automated changes, I did look through the other commits. LGTM.
I can see there are a few ID-TBDs we need to get sorted.
PR #37329: Size comparison from 35781e5 to b626984 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
This is the DM XML pull of the spec at the 1.5 0.7 ballot tag. The data model XML pull was done with alchemy because the legacy data model editor scraper cannot parse the new spec, so there are significant number of changes. I have done my best to separate the functional from the scraped changes into different commits. A summary of the differences between 1.4 and master i given below. Note that the element level changes to the devices types are not captured here since the tooling does not currently parse these.
Testing
Tests in TestSpecParsingDeviceType.py are updated. TestSpecParsingSupport.py also run (and runs in CI)