Create an AAI registry for PwRPC services to allow registration of custom AAI classes #37351

sxb427 · 2025-02-02T10:57:54Z

Chef delegates can now register attribute access classes in AttributeAccessorRegistry to serve PwRPC write requests. It is not ideal for PwRPC writes to take the same path as Matter Attribute Writes, as they have no constraint of being spec compliant. This PR adds the support for PwRPC write requests to directly reach custom handlers without going through Matter Attribute Writes pathway.

When attribute access registration is not found, it falls back to the old route.

Testing

Added the following custom handler in chef-air-quality.cpp

class AirQualityAttrAccess : public chip::rpc::PigweedDebugAccessInterceptor
{
public:
    AirQualityAttrAccess() = default;

    std::optional<pw::Status> Write(const ConcreteDataAttributePath & aPath, AttributeValueDecoder & aDecoder) override
    {

        ChipLogProgress(DeviceLayer, "AirQualityAttrAccessRpc Write");

        if (aPath.mClusterId != AirQuality::Id)
        {
            ChipLogError(DeviceLayer, "AirQualityAttrAccessRpc Write: accessor does not support cluster %u. Bypassing.",
                         aPath.mClusterId);
            return std::nullopt;
        }

        Instance * clusterInstance = gAirQualityClusterInstance[aPath.mEndpointId];

        switch (aPath.mAttributeId)
        {
        case chip::app::Clusters::AirQuality::Attributes::AirQuality::Id: {
            AirQualityEnum finalValue;
            CHIP_ERROR decoded = aDecoder.Decode(finalValue);
            if (decoded != CHIP_NO_ERROR)
            {
                ChipLogError(DeviceLayer, "AirQualityAttrAccessRpc Write: Decoder failed %" CHIP_ERROR_FORMAT, decoded.Format());
                return pw::Status::Internal();
            }
            Protocols::InteractionModel::Status status = clusterInstance->UpdateAirQuality(finalValue);
            if (Protocols::InteractionModel::Status::Success != status)
            {
                ChipLogError(DeviceLayer, "AirQualityAttrAccessRpc Write: UpdateAirQuality failed");
                return pw::Status::Internal();
            }
            return pw::OkStatus();
        }
        break;
        default: {
            ChipLogProgress(DeviceLayer, "AirQualityAttrAccessRpc Write: Permission denied for write to attribute %u",
                            aPath.mAttributeId);
            return pw::Status::PermissionDenied(); // Block writes to other attributes
        }
        }

        return std::nullopt;
    }
};

AirQualityAttrAccess rpcAai;

.
.
.

void emberAfAirQualityClusterInitCallback(...)
{
    ...
    chip::rpc::PigweedDebugAccessInterceptorRegistry::Instance().Register(&rpcAai);
}

Tested with rootnode_airqualitysensor_e63187f6c9

Send Write via RPC console -

rpcs.chip.rpc.Attributes.Write(data=protos.chip.rpc.AttributeData(data_uint8=3), metadata=protos.chip.rpc.AttributeMetadata(endpoint=1, cluster=int("0x005B", 16), attribute_id=0, type=protos.chip.rpc.AttributeType.ZCL_ENUM8_ATTRIBUTE_TYPE))

Read value

rpcs.chip.rpc.Attributes.Read(endpoint=1, cluster=int("0x005B", 16), attribute_id=0, type=protos.chip.rpc.AttributeType.ZCL_ENUM8_ATTRIBUTE_TYPE, pw_rpc_timeout_s=1000)

Output = 3

Logs -

[1738783912.049678][9:11] CHIP:DL: AirQualityAttrAccessRpc Write
[1738783912.049704][9:11] CHIP:DMG: Endpoint 1, Cluster 0x0000_005B update version to 44ef09c6
[1738783980.371804][9:11] CHIP:DMG: Reading attribute: Cluster=0x0000_005B Endpoint=0x1 AttributeId=0x0000_0000 (expanded=0)

Testing backwards compatibility

Device: rootnode_airqualitysensor_e63187f6c9

Set MeasuredValue to 421.5

rpcs.chip.rpc.Attributes.Write(data=protos.chip.rpc.AttributeData(data_single=421.5), metadata=protos.chip.rpc.AttributeMetadata(endpoint=1, cluster=int("0x040D", 16), attribute_id=0, type=protos.chip.rpc.AttributeType.ZCL_DOUBLE_ATTRIBUTE_TYPE))

Read MeasuredValue

./chip-tool carbondioxideconcentrationmeasurement read measured-value 0x20 1 | grep "MeasuredValue"

Output: 421.5

Logs -

[1738784035.671899][9:11] CHIP:DL: AirQualityAttrAccessRpc Write
[1738784035.671920][9:11] CHIP:DL: AirQualityAttrAccessRpc Write: accessor does not support cluster 1037. Bypassing.
[1738784035.671925][9:11] CHIP:SPT: No custom PigweedRPC Attribute Accessor registration found for: endpoint=1 cluster=1037, using fake write access.
[1738784035.671928][9:11] CHIP:DMG: Writing attribute: Cluster=0x0000_040D Endpoint=0x1 AttributeId=0x0000_0000
[1738784035.671941][9:11] CHIP:DL: Updated EP:1, Cluster: 0x040d MeasuredValue
[1738784035.671947][9:11] CHIP:DMG: Endpoint 1, Cluster 0x0000_040D update version to d28e22af
[1738784035.671951][9:11] CHIP:ZCL: Cluster callback: 0x0000_040D

…ites to look for custom AAIs before using datamodel provider

semanticdiff-com · 2025-02-02T10:57:57Z

Review changes with

github-actions · 2025-02-02T11:09:58Z

PR #37351: Size comparison from 95d5de5 to a130e5f

Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)

platform	target	config	section	`95d5de5`	`a130e5f`	change	% change
bl602	lighting-app	bl602+mfd+littlefs+rpc	FLASH	1093546	1093968	422	0.0
			RAM	103298	103330	32	0.0
bl702	lighting-app	bl702+eth	FLASH	650158	650158	0	0.0
			RAM	25265	25265	0	0.0
		bl702+wifi	FLASH	828066	828066	0	0.0
			RAM	13981	13981	0	0.0
		bl706+mfd+rpc+littlefs	FLASH	1056626	1057052	426	0.0
			RAM	23861	23893	32	0.1
bl702l	contact-sensor-app	bl702l+mfd+littlefs	FLASH	888060	888058	-2	-0.0
			RAM	18504	18504	0	0.0
	lighting-app	bl702l+mfd+littlefs	FLASH	971046	971044	-2	-0.0
			RAM	16368	16368	0	0.0
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	838032	838080	48	0.0
			RAM	123464	123464	0	0.0
	lock-ftd	LP_EM_CC1354P10_6	FLASH	823436	823500	64	0.0
			RAM	125344	125344	0	0.0
	pump-app	LP_EM_CC1354P10_6	FLASH	770676	770724	48	0.0
			RAM	113804	113804	0	0.0
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	754920	754968	48	0.0
			RAM	114012	114012	0	0.0
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	538461	538525	64	0.0
			RAM	205192	205192	0	0.0
	lock	CC3235SF_LAUNCHXL	FLASH	572325	572389	64	0.0
			RAM	205344	205344	0	0.0
cyw30739	light	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	679433	679489	56	0.0
			RAM	78532	78532	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	699285	699341	56	0.0
			RAM	81172	81172	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	699285	699341	56	0.0
			RAM	81172	81172	0	0.0
		CYW930739M2EVB-02	unknown	2040	2040	0	0.0
			FLASH	656213	656269	56	0.0
			RAM	73600	73600	0	0.0
	light-switch	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	615817	615873	56	0.0
			RAM	71516	71516	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	635445	635501	56	0.0
			RAM	74060	74060	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	635445	635501	56	0.0
			RAM	74060	74060	0	0.0
	lock	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	635289	635353	64	0.0
			RAM	74524	74524	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	654997	655061	64	0.0
			RAM	77068	77068	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	654997	655061	64	0.0
			RAM	77068	77068	0	0.0
	thermostat	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	611725	611789	64	0.0
			RAM	68612	68612	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	631585	631649	64	0.0
			RAM	71252	71252	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	631585	631649	64	0.0
			RAM	71252	71252	0	0.0
linux	air-purifier-app	debug	unknown	4760	4760	0	0.0
			FLASH	2708945	2708945	0	0.0
			RAM	132816	132816	0	0.0
	all-clusters-app	debug	unknown	5568	5568	0	0.0
			FLASH	5974968	5974968	0	0.0
			RAM	531632	531632	0	0.0
	all-clusters-minimal-app	debug	unknown	5464	5464	0	0.0
			FLASH	`5323654`	`5323654`	0	0.0
			RAM	242744	242744	0	0.0
	bridge-app	debug	unknown	5480	5480	0	0.0
			FLASH	4681842	4681842	0	0.0
			RAM	221480	221480	0	0.0
	chip-tool	debug	unknown	6120	6120	0	0.0
			FLASH	13098730	13098730	0	0.0
			RAM	596770	596770	0	0.0
	chip-tool-ipv6only	arm64	unknown	21848	21848	0	0.0
			FLASH	11164208	11164208	0	0.0
			RAM	648496	648496	0	0.0
	fabric-admin	debug	unknown	5808	5808	0	0.0
			FLASH	11388203	11388203	0	0.0
			RAM	596554	596554	0	0.0
	fabric-bridge-app	debug	unknown	4736	4736	0	0.0
			FLASH	`4506440`	`4506440`	0	0.0
			RAM	208664	208664	0	0.0
	fabric-sync	debug	unknown	4976	4976	0	0.0
			FLASH	5612821	5612821	0	0.0
			RAM	483536	483536	0	0.0
	lighting-app	debug+rpc+ui	unknown	6144	6144	0	0.0
			FLASH	5624593	5625233	640	0.0
			RAM	231760	231824	64	0.0
	lock-app	debug	unknown	5416	5416	0	0.0
			FLASH	4730956	4730956	0	0.0
			RAM	207728	207728	0	0.0
	ota-provider-app	debug	unknown	4776	4776	0	0.0
			FLASH	4359500	4359500	0	0.0
			RAM	201368	201368	0	0.0
	ota-requestor-app	debug	unknown	4728	4728	0	0.0
			FLASH	4496972	4496972	0	0.0
			RAM	205952	205952	0	0.0
	shell	debug	unknown	4256	4256	0	0.0
			FLASH	3004877	3004877	0	0.0
			RAM	160504	160504	0	0.0
	thermostat-no-ble	arm64	unknown	9536	9536	0	0.0
			FLASH	4098768	4098768	0	0.0
			RAM	246144	246144	0	0.0
	tv-app	debug	unknown	5744	5744	0	0.0
			FLASH	5952421	5952421	0	0.0
			RAM	606936	606936	0	0.0
	tv-casting-app	debug	unknown	5320	5320	0	0.0
			FLASH	11272333	11272333	0	0.0
			RAM	710896	710896	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	906992	907052	60	0.0
			RAM	142395	142395	0	0.0
		nrf7002dk_nrf5340_cpuapp	FLASH	901532	901532	0	0.0
			RAM	124739	124739	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	845716	845776	60	0.0
			RAM	141323	141323	0	0.0
nxp	contact	k32w0+release	FLASH	584304	584368	64	0.0
			RAM	70860	70860	0	0.0
		mcxw71+release	FLASH	599664	599712	48	0.0
			RAM	63080	63080	0	0.0
	light	k32w0+release	FLASH	610748	610812	64	0.0
			RAM	70252	70252	0	0.0
		k32w1+release	FLASH	685208	685272	64	0.0
			RAM	48664	48664	0	0.0
	lock	mcxw71+release	FLASH	748680	748744	64	0.0
			RAM	67476	67476	0	0.0
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1646356	1646356	0	0.0
			RAM	211560	211560	0	0.0
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	1553148	1553148	0	0.0
			RAM	208376	208376	0	0.0
	light	cy8ckit_062s2_43012	FLASH	1468828	1468828	0	0.0
			RAM	200352	200352	0	0.0
	lock	cy8ckit_062s2_43012	FLASH	1466860	1466860	0	0.0
			RAM	224688	224688	0	0.0
qpg	lighting-app	qpg6105+debug	FLASH	662016	662080	64	0.0
			RAM	105204	105204	0	0.0
	lock-app	qpg6105+debug	FLASH	619804	619868	64	0.0
			RAM	99648	99648	0	0.0
stm32	light	STM32WB5MM-DK	FLASH	482624	482688	64	0.0
			RAM	144672	144672	0	0.0
telink	bridge-app	tl7218x	FLASH	664774	664820	46	0.0
			RAM	90812	90812	0	0.0
	contact-sensor-app	tlsr9528a_retention	FLASH	621532	621578	46	0.0
			RAM	31484	31484	0	0.0
	light-app-ota-shell-factory-data	tl3218x	FLASH	770284	770330	46	0.0
			RAM	43552	43552	0	0.0
		tl7218x	FLASH	778816	778862	46	0.0
			RAM	98688	98688	0	0.0
	light-switch-app-ota-compress-lzma-factory-data	tl7218x_retention	FLASH	680150	680196	46	0.0
			RAM	52176	52176	0	0.0
	light-switch-app-ota-compress-lzma-shell-factory-data	tlsr9528a	FLASH	708704	708750	46	0.0
			RAM	73384	73384	0	0.0
	lighting-app-ota-factory-data	tlsr9118bdk40d	FLASH	625618	625664	46	0.0
			RAM	142016	142016	0	0.0
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	FLASH	813000	813150	150	0.0
			RAM	99560	99596	36	0.0
tizen	all-clusters-app	arm	unknown	5116	5116	0	0.0
			FLASH	1751916	1751916	0	0.0
			RAM	93524	93524	0	0.0
	chip-tool-ubsan	arm	unknown	11408	11408	0	0.0
			FLASH	18698198	18698198	0	0.0
			RAM	8183840	8183840	0	0.0

examples/common/pigweed/rpc_services/Attributes.h

src/data-model-providers/codegen/CodegenDataModelProvider.h

examples/common/pigweed/rpc_services/Attributes.h

andy31415

code in src/data-model-providers should not be touched for example development.

Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>

github-actions · 2025-02-03T22:05:44Z

PR #37351: Size comparison from 95d5de5 to 4393084

Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)

platform	target	config	section	`95d5de5`	`4393084`	change	% change
bl602	lighting-app	bl602+mfd+littlefs+rpc	FLASH	1093546	1093966	420	0.0
			RAM	103298	103330	32	0.0
bl702	lighting-app	bl702+eth	FLASH	650158	650154	-4	-0.0
			RAM	25265	25265	0	0.0
		bl702+wifi	FLASH	828066	828062	-4	-0.0
			RAM	13981	13981	0	0.0
		bl706+mfd+rpc+littlefs	FLASH	1056626	`1057050`	424	0.0
			RAM	23861	23893	32	0.1
bl702l	contact-sensor-app	bl702l+mfd+littlefs	FLASH	888060	888056	-4	-0.0
			RAM	18504	18504	0	0.0
	lighting-app	bl702l+mfd+littlefs	FLASH	971046	971042	-4	-0.0
			RAM	16368	16368	0	0.0
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	838032	838080	48	0.0
			RAM	123464	123464	0	0.0
	lock-ftd	LP_EM_CC1354P10_6	FLASH	823436	823500	64	0.0
			RAM	125344	125344	0	0.0
	pump-app	LP_EM_CC1354P10_6	FLASH	770676	770724	48	0.0
			RAM	113804	113804	0	0.0
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	754920	754968	48	0.0
			RAM	114012	114012	0	0.0
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	538461	538525	64	0.0
			RAM	205192	205192	0	0.0
	lock	CC3235SF_LAUNCHXL	FLASH	572325	572381	56	0.0
			RAM	205344	205344	0	0.0
cyw30739	light	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	679433	679489	56	0.0
			RAM	78532	78532	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	699285	699333	48	0.0
			RAM	81172	81172	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	699285	699333	48	0.0
			RAM	81172	81172	0	0.0
		CYW930739M2EVB-02	unknown	2040	2040	0	0.0
			FLASH	656213	656269	56	0.0
			RAM	73600	73600	0	0.0
	light-switch	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	615817	615865	48	0.0
			RAM	71516	71516	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	635445	635493	48	0.0
			RAM	74060	74060	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	635445	635493	48	0.0
			RAM	74060	74060	0	0.0
	lock	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	635289	635353	64	0.0
			RAM	74524	74524	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	654997	655061	64	0.0
			RAM	77068	77068	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	654997	655061	64	0.0
			RAM	77068	77068	0	0.0
	thermostat	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	611725	611789	64	0.0
			RAM	68612	68612	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	631585	631649	64	0.0
			RAM	71252	71252	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	631585	631649	64	0.0
			RAM	71252	71252	0	0.0
linux	air-purifier-app	debug	unknown	4760	4760	0	0.0
			FLASH	2708945	2708945	0	0.0
			RAM	132816	132816	0	0.0
	all-clusters-app	debug	unknown	5568	5568	0	0.0
			FLASH	5974968	5974968	0	0.0
			RAM	531632	531632	0	0.0
	all-clusters-minimal-app	debug	unknown	5464	5464	0	0.0
			FLASH	`5323654`	`5323654`	0	0.0
			RAM	242744	242744	0	0.0
	bridge-app	debug	unknown	5480	5480	0	0.0
			FLASH	4681842	4681842	0	0.0
			RAM	221480	221480	0	0.0
	chip-tool	debug	unknown	6120	6120	0	0.0
			FLASH	13098730	13098730	0	0.0
			RAM	596770	596770	0	0.0
	chip-tool-ipv6only	arm64	unknown	21848	21848	0	0.0
			FLASH	11164208	11164224	16	0.0
			RAM	648496	648496	0	0.0
	fabric-admin	debug	unknown	5808	5808	0	0.0
			FLASH	11388203	11388203	0	0.0
			RAM	596554	596554	0	0.0
	fabric-bridge-app	debug	unknown	4736	4736	0	0.0
			FLASH	`4506440`	`4506440`	0	0.0
			RAM	208664	208664	0	0.0
	fabric-sync	debug	unknown	4976	4976	0	0.0
			FLASH	5612821	5612821	0	0.0
			RAM	483536	483536	0	0.0
	lighting-app	debug+rpc+ui	unknown	6144	6144	0	0.0
			FLASH	5624593	5625233	640	0.0
			RAM	231760	231824	64	0.0
	lock-app	debug	unknown	5416	5416	0	0.0
			FLASH	4730956	4730956	0	0.0
			RAM	207728	207728	0	0.0
	ota-provider-app	debug	unknown	4776	4776	0	0.0
			FLASH	4359500	4359500	0	0.0
			RAM	201368	201368	0	0.0
	ota-requestor-app	debug	unknown	4728	4728	0	0.0
			FLASH	4496972	4496972	0	0.0
			RAM	205952	205952	0	0.0
	shell	debug	unknown	4256	4256	0	0.0
			FLASH	3004877	3004877	0	0.0
			RAM	160504	160504	0	0.0
	thermostat-no-ble	arm64	unknown	9536	9536	0	0.0
			FLASH	4098768	4098784	16	0.0
			RAM	246144	246144	0	0.0
	tv-app	debug	unknown	5744	5744	0	0.0
			FLASH	5952421	5952421	0	0.0
			RAM	606936	606936	0	0.0
	tv-casting-app	debug	unknown	5320	5320	0	0.0
			FLASH	11272333	11272333	0	0.0
			RAM	710896	710896	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	906992	907052	60	0.0
			RAM	142395	142395	0	0.0
		nrf7002dk_nrf5340_cpuapp	FLASH	901532	901532	0	0.0
			RAM	124739	124739	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	845716	845776	60	0.0
			RAM	141323	141323	0	0.0
nxp	contact	k32w0+release	FLASH	584304	584368	64	0.0
			RAM	70860	70860	0	0.0
		mcxw71+release	FLASH	599664	599712	48	0.0
			RAM	63080	63080	0	0.0
	light	k32w0+release	FLASH	610748	610812	64	0.0
			RAM	70252	70252	0	0.0
		k32w1+release	FLASH	685208	685272	64	0.0
			RAM	48664	48664	0	0.0
	lock	mcxw71+release	FLASH	748680	748744	64	0.0
			RAM	67476	67476	0	0.0
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1646356	1646356	0	0.0
			RAM	211560	211560	0	0.0
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	1553148	1553148	0	0.0
			RAM	208376	208376	0	0.0
	light	cy8ckit_062s2_43012	FLASH	1468828	1468828	0	0.0
			RAM	200352	200352	0	0.0
	lock	cy8ckit_062s2_43012	FLASH	1466860	1466860	0	0.0
			RAM	224688	224688	0	0.0
qpg	lighting-app	qpg6105+debug	FLASH	662016	662080	64	0.0
			RAM	105204	105204	0	0.0
	lock-app	qpg6105+debug	FLASH	619804	619860	56	0.0
			RAM	99648	99648	0	0.0
stm32	light	STM32WB5MM-DK	FLASH	482624	482688	64	0.0
			RAM	144672	144672	0	0.0
telink	bridge-app	tl7218x	FLASH	664774	664818	44	0.0
			RAM	90812	90812	0	0.0
	contact-sensor-app	tlsr9528a_retention	FLASH	621532	621576	44	0.0
			RAM	31484	31484	0	0.0
	light-app-ota-shell-factory-data	tl3218x	FLASH	770284	770328	44	0.0
			RAM	43552	43552	0	0.0
		tl7218x	FLASH	778816	778860	44	0.0
			RAM	98688	98688	0	0.0
	light-switch-app-ota-compress-lzma-factory-data	tl7218x_retention	FLASH	680150	680194	44	0.0
			RAM	52176	52176	0	0.0
	light-switch-app-ota-compress-lzma-shell-factory-data	tlsr9528a	FLASH	708704	708748	44	0.0
			RAM	73384	73384	0	0.0
	lighting-app-ota-factory-data	tlsr9118bdk40d	FLASH	625618	625662	44	0.0
			RAM	142016	142016	0	0.0
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	FLASH	813000	813148	148	0.0
			RAM	99560	99596	36	0.0
tizen	all-clusters-app	arm	unknown	5116	5116	0	0.0
			FLASH	1751916	1751908	-8	-0.0
			RAM	93524	93524	0	0.0
	chip-tool-ubsan	arm	unknown	11408	11408	0	0.0
			FLASH	18698198	18698190	-8	-0.0
			RAM	8183840	8183840	0	0.0

github-actions · 2025-02-04T03:23:00Z

PR #37351: Size comparison from 95d5de5 to a8bcf87

Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)

platform	target	config	section	`95d5de5`	`a8bcf87`	change	% change
bl602	lighting-app	bl602+mfd+littlefs+rpc	FLASH	1093546	1094398	852	0.1
			RAM	103298	103354	56	0.1
bl702	lighting-app	bl702+eth	FLASH	650158	650154	-4	-0.0
			RAM	25265	25265	0	0.0
		bl702+wifi	FLASH	828066	828062	-4	-0.0
			RAM	13981	13981	0	0.0
		bl706+mfd+rpc+littlefs	FLASH	1056626	1057514	888	0.1
			RAM	23861	23909	48	0.2
bl702l	contact-sensor-app	bl702l+mfd+littlefs	FLASH	888060	888056	-4	-0.0
			RAM	18504	18504	0	0.0
	lighting-app	bl702l+mfd+littlefs	FLASH	971046	971042	-4	-0.0
			RAM	16368	16368	0	0.0
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	838032	838032	0	0.0
			RAM	123464	123464	0	0.0
	lock-ftd	LP_EM_CC1354P10_6	FLASH	823436	823436	0	0.0
			RAM	125344	125344	0	0.0
	pump-app	LP_EM_CC1354P10_6	FLASH	770676	770676	0	0.0
			RAM	113804	113804	0	0.0
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	754920	754920	0	0.0
			RAM	114012	114012	0	0.0
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	538461	538461	0	0.0
			RAM	205192	205192	0	0.0
	lock	CC3235SF_LAUNCHXL	FLASH	572325	572317	-8	-0.0
			RAM	205344	205344	0	0.0
cyw30739	light	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	679433	679433	0	0.0
			RAM	78532	78532	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	699285	699277	-8	-0.0
			RAM	81172	81172	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	699285	699277	-8	-0.0
			RAM	81172	81172	0	0.0
		CYW930739M2EVB-02	unknown	2040	2040	0	0.0
			FLASH	656213	656213	0	0.0
			RAM	73600	73600	0	0.0
	light-switch	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	615817	615809	-8	-0.0
			RAM	71516	71516	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	635445	635437	-8	-0.0
			RAM	74060	74060	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	635445	635437	-8	-0.0
			RAM	74060	74060	0	0.0
	lock	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	635289	635289	0	0.0
			RAM	74524	74524	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	654997	654997	0	0.0
			RAM	77068	77068	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	654997	654997	0	0.0
			RAM	77068	77068	0	0.0
	thermostat	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	611725	611725	0	0.0
			RAM	68612	68612	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	631585	631585	0	0.0
			RAM	71252	71252	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	631585	631585	0	0.0
			RAM	71252	71252	0	0.0
linux	air-purifier-app	debug	unknown	4760	4760	0	0.0
			FLASH	2708945	2708945	0	0.0
			RAM	132816	132816	0	0.0
	all-clusters-app	debug	unknown	5568	5568	0	0.0
			FLASH	5974968	5974968	0	0.0
			RAM	531632	531632	0	0.0
	all-clusters-minimal-app	debug	unknown	5464	5464	0	0.0
			FLASH	`5323654`	`5323654`	0	0.0
			RAM	242744	242744	0	0.0
	bridge-app	debug	unknown	5480	5480	0	0.0
			FLASH	4681842	4681842	0	0.0
			RAM	221480	221480	0	0.0
	chip-tool	debug	unknown	6120	6120	0	0.0
			FLASH	13098730	13098730	0	0.0
			RAM	596770	596770	0	0.0
	chip-tool-ipv6only	arm64	unknown	21848	21848	0	0.0
			FLASH	11164208	11164224	16	0.0
			RAM	648496	648496	0	0.0
	fabric-admin	debug	unknown	5808	5808	0	0.0
			FLASH	11388203	11388203	0	0.0
			RAM	596554	596554	0	0.0
	fabric-bridge-app	debug	unknown	4736	4736	0	0.0
			FLASH	`4506440`	`4506440`	0	0.0
			RAM	208664	208664	0	0.0
	fabric-sync	debug	unknown	4976	4976	0	0.0
			FLASH	5612821	5612821	0	0.0
			RAM	483536	483536	0	0.0
	lighting-app	debug+rpc+ui	unknown	6144	6152	8	0.1
			FLASH	5624593	5631505	6912	0.1
			RAM	231760	231888	128	0.1
	lock-app	debug	unknown	5416	5416	0	0.0
			FLASH	4730956	4730956	0	0.0
			RAM	207728	207728	0	0.0
	ota-provider-app	debug	unknown	4776	4776	0	0.0
			FLASH	4359500	4359500	0	0.0
			RAM	201368	201368	0	0.0
	ota-requestor-app	debug	unknown	4728	4728	0	0.0
			FLASH	4496972	4496972	0	0.0
			RAM	205952	205952	0	0.0
	shell	debug	unknown	4256	4256	0	0.0
			FLASH	3004877	3004877	0	0.0
			RAM	160504	160504	0	0.0
	thermostat-no-ble	arm64	unknown	9536	9536	0	0.0
			FLASH	4098768	4098784	16	0.0
			RAM	246144	246144	0	0.0
	tv-app	debug	unknown	5744	5744	0	0.0
			FLASH	5952421	5952421	0	0.0
			RAM	606936	606936	0	0.0
	tv-casting-app	debug	unknown	5320	5320	0	0.0
			FLASH	11272333	11272333	0	0.0
			RAM	710896	710896	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	906992	906988	-4	-0.0
			RAM	142395	142395	0	0.0
		nrf7002dk_nrf5340_cpuapp	FLASH	901532	901532	0	0.0
			RAM	124739	124739	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	845716	845712	-4	-0.0
			RAM	141323	141323	0	0.0
nxp	contact	k32w0+release	FLASH	584304	584304	0	0.0
			RAM	70860	70860	0	0.0
		mcxw71+release	FLASH	599664	599664	0	0.0
			RAM	63080	63080	0	0.0
	light	k32w0+release	FLASH	610748	610748	0	0.0
			RAM	70252	70252	0	0.0
		k32w1+release	FLASH	685208	685208	0	0.0
			RAM	48664	48664	0	0.0
	lock	mcxw71+release	FLASH	748680	748680	0	0.0
			RAM	67476	67476	0	0.0
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1646356	1646356	0	0.0
			RAM	211560	211560	0	0.0
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	1553148	1553148	0	0.0
			RAM	208376	208376	0	0.0
	light	cy8ckit_062s2_43012	FLASH	1468828	1468828	0	0.0
			RAM	200352	200352	0	0.0
	lock	cy8ckit_062s2_43012	FLASH	1466860	1466860	0	0.0
			RAM	224688	224688	0	0.0
qpg	lighting-app	qpg6105+debug	FLASH	662016	662016	0	0.0
			RAM	105204	105204	0	0.0
	lock-app	qpg6105+debug	FLASH	619804	619796	-8	-0.0
			RAM	99648	99648	0	0.0
stm32	light	STM32WB5MM-DK	FLASH	482624	482624	0	0.0
			RAM	144672	144672	0	0.0
telink	bridge-app	tl7218x	FLASH	664774	664772	-2	-0.0
			RAM	90812	90812	0	0.0
	contact-sensor-app	tlsr9528a_retention	FLASH	621532	621530	-2	-0.0
			RAM	31484	31484	0	0.0
	light-app-ota-shell-factory-data	tl3218x	FLASH	770284	770282	-2	-0.0
			RAM	43552	43552	0	0.0
		tl7218x	FLASH	778816	778814	-2	-0.0
			RAM	98688	98688	0	0.0
	light-switch-app-ota-compress-lzma-factory-data	tl7218x_retention	FLASH	680150	680148	-2	-0.0
			RAM	52176	52176	0	0.0
	light-switch-app-ota-compress-lzma-shell-factory-data	tlsr9528a	FLASH	708704	708702	-2	-0.0
			RAM	73384	73384	0	0.0
	lighting-app-ota-factory-data	tlsr9118bdk40d	FLASH	625618	625616	-2	-0.0
			RAM	142016	142016	0	0.0
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	FLASH	813000	813638	638	0.1
			RAM	99560	99616	56	0.1
tizen	all-clusters-app	arm	unknown	5116	5116	0	0.0
			FLASH	1751916	1751908	-8	-0.0
			RAM	93524	93524	0	0.0
	chip-tool-ubsan	arm	unknown	11408	11408	0	0.0
			FLASH	18698198	18698190	-8	-0.0
			RAM	8183840	8183840	0	0.0

github-actions · 2025-02-04T06:39:20Z

PR #37351: Size comparison from 95d5de5 to 95c1d6b

Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)

platform	target	config	section	`95d5de5`	`95c1d6b`	change	% change
bl602	lighting-app	bl602+mfd+littlefs+rpc	FLASH	1093546	1094398	852	0.1
			RAM	103298	103354	56	0.1
bl702	lighting-app	bl702+eth	FLASH	650158	650154	-4	-0.0
			RAM	25265	25265	0	0.0
		bl702+wifi	FLASH	828066	828062	-4	-0.0
			RAM	13981	13981	0	0.0
		bl706+mfd+rpc+littlefs	FLASH	1056626	1057514	888	0.1
			RAM	23861	23909	48	0.2
bl702l	contact-sensor-app	bl702l+mfd+littlefs	FLASH	888060	888056	-4	-0.0
			RAM	18504	18504	0	0.0
	lighting-app	bl702l+mfd+littlefs	FLASH	971046	971042	-4	-0.0
			RAM	16368	16368	0	0.0
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	838032	838032	0	0.0
			RAM	123464	123464	0	0.0
	lock-ftd	LP_EM_CC1354P10_6	FLASH	823436	823436	0	0.0
			RAM	125344	125344	0	0.0
	pump-app	LP_EM_CC1354P10_6	FLASH	770676	770676	0	0.0
			RAM	113804	113804	0	0.0
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	754920	754920	0	0.0
			RAM	114012	114012	0	0.0
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	538461	538461	0	0.0
			RAM	205192	205192	0	0.0
	lock	CC3235SF_LAUNCHXL	FLASH	572325	572317	-8	-0.0
			RAM	205344	205344	0	0.0
cyw30739	light	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	679433	679433	0	0.0
			RAM	78532	78532	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	699285	699277	-8	-0.0
			RAM	81172	81172	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	699285	699277	-8	-0.0
			RAM	81172	81172	0	0.0
		CYW930739M2EVB-02	unknown	2040	2040	0	0.0
			FLASH	656213	656213	0	0.0
			RAM	73600	73600	0	0.0
	light-switch	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	615817	615809	-8	-0.0
			RAM	71516	71516	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	635445	635437	-8	-0.0
			RAM	74060	74060	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	635445	635437	-8	-0.0
			RAM	74060	74060	0	0.0
	lock	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	635289	635289	0	0.0
			RAM	74524	74524	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	654997	654997	0	0.0
			RAM	77068	77068	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	654997	654997	0	0.0
			RAM	77068	77068	0	0.0
	thermostat	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	611725	611725	0	0.0
			RAM	68612	68612	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	631585	631585	0	0.0
			RAM	71252	71252	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	631585	631585	0	0.0
			RAM	71252	71252	0	0.0
linux	air-purifier-app	debug	unknown	4760	4760	0	0.0
			FLASH	2708945	2708945	0	0.0
			RAM	132816	132816	0	0.0
	all-clusters-app	debug	unknown	5568	5568	0	0.0
			FLASH	5974968	5974968	0	0.0
			RAM	531632	531632	0	0.0
	all-clusters-minimal-app	debug	unknown	5464	5464	0	0.0
			FLASH	`5323654`	`5323654`	0	0.0
			RAM	242744	242744	0	0.0
	bridge-app	debug	unknown	5480	5480	0	0.0
			FLASH	4681842	4681842	0	0.0
			RAM	221480	221480	0	0.0
	chip-tool	debug	unknown	6120	6120	0	0.0
			FLASH	13098730	13098730	0	0.0
			RAM	596770	596770	0	0.0
	chip-tool-ipv6only	arm64	unknown	21848	21848	0	0.0
			FLASH	11164208	11164224	16	0.0
			RAM	648496	648496	0	0.0
	fabric-admin	debug	unknown	5808	5808	0	0.0
			FLASH	11388203	11388203	0	0.0
			RAM	596554	596554	0	0.0
	fabric-bridge-app	debug	unknown	4736	4736	0	0.0
			FLASH	`4506440`	`4506440`	0	0.0
			RAM	208664	208664	0	0.0
	fabric-sync	debug	unknown	4976	4976	0	0.0
			FLASH	5612821	5612821	0	0.0
			RAM	483536	483536	0	0.0
	lighting-app	debug+rpc+ui	unknown	6144	6152	8	0.1
			FLASH	5624593	5631505	6912	0.1
			RAM	231760	231888	128	0.1
	lock-app	debug	unknown	5416	5416	0	0.0
			FLASH	4730956	4730956	0	0.0
			RAM	207728	207728	0	0.0
	ota-provider-app	debug	unknown	4776	4776	0	0.0
			FLASH	4359500	4359500	0	0.0
			RAM	201368	201368	0	0.0
	ota-requestor-app	debug	unknown	4728	4728	0	0.0
			FLASH	4496972	4496972	0	0.0
			RAM	205952	205952	0	0.0
	shell	debug	unknown	4256	4256	0	0.0
			FLASH	3004877	3004877	0	0.0
			RAM	160504	160504	0	0.0
	thermostat-no-ble	arm64	unknown	9536	9536	0	0.0
			FLASH	4098768	4098784	16	0.0
			RAM	246144	246144	0	0.0
	tv-app	debug	unknown	5744	5744	0	0.0
			FLASH	5952421	5952421	0	0.0
			RAM	606936	606936	0	0.0
	tv-casting-app	debug	unknown	5320	5320	0	0.0
			FLASH	11272333	11272333	0	0.0
			RAM	710896	710896	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	906992	906988	-4	-0.0
			RAM	142395	142395	0	0.0
		nrf7002dk_nrf5340_cpuapp	FLASH	901532	901532	0	0.0
			RAM	124739	124739	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	845716	845712	-4	-0.0
			RAM	141323	141323	0	0.0
nxp	contact	k32w0+release	FLASH	584304	584304	0	0.0
			RAM	70860	70860	0	0.0
		mcxw71+release	FLASH	599664	599664	0	0.0
			RAM	63080	63080	0	0.0
	light	k32w0+release	FLASH	610748	610748	0	0.0
			RAM	70252	70252	0	0.0
		k32w1+release	FLASH	685208	685208	0	0.0
			RAM	48664	48664	0	0.0
	lock	mcxw71+release	FLASH	748680	748680	0	0.0
			RAM	67476	67476	0	0.0
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1646356	1646356	0	0.0
			RAM	211560	211560	0	0.0
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	1553148	1553148	0	0.0
			RAM	208376	208376	0	0.0
	light	cy8ckit_062s2_43012	FLASH	1468828	1468828	0	0.0
			RAM	200352	200352	0	0.0
	lock	cy8ckit_062s2_43012	FLASH	1466860	1466860	0	0.0
			RAM	224688	224688	0	0.0
qpg	lighting-app	qpg6105+debug	FLASH	662016	662016	0	0.0
			RAM	105204	105204	0	0.0
	lock-app	qpg6105+debug	FLASH	619804	619796	-8	-0.0
			RAM	99648	99648	0	0.0
stm32	light	STM32WB5MM-DK	FLASH	482624	482624	0	0.0
			RAM	144672	144672	0	0.0
telink	bridge-app	tl7218x	FLASH	664774	664772	-2	-0.0
			RAM	90812	90812	0	0.0
	contact-sensor-app	tlsr9528a_retention	FLASH	621532	621530	-2	-0.0
			RAM	31484	31484	0	0.0
	light-app-ota-shell-factory-data	tl3218x	FLASH	770284	770282	-2	-0.0
			RAM	43552	43552	0	0.0
		tl7218x	FLASH	778816	778814	-2	-0.0
			RAM	98688	98688	0	0.0
	light-switch-app-ota-compress-lzma-factory-data	tl7218x_retention	FLASH	680150	680148	-2	-0.0
			RAM	52176	52176	0	0.0
	light-switch-app-ota-compress-lzma-shell-factory-data	tlsr9528a	FLASH	708704	708702	-2	-0.0
			RAM	73384	73384	0	0.0
	lighting-app-ota-factory-data	tlsr9118bdk40d	FLASH	625618	625616	-2	-0.0
			RAM	142016	142016	0	0.0
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	FLASH	813000	813638	638	0.1
			RAM	99560	99616	56	0.1
tizen	all-clusters-app	arm	unknown	5116	5116	0	0.0
			FLASH	1751916	1751908	-8	-0.0
			RAM	93524	93524	0	0.0
	chip-tool-ubsan	arm	unknown	11408	11408	0	0.0
			FLASH	18698198	18698190	-8	-0.0
			RAM	8183840	8183840	0	0.0

examples/common/pigweed/rpc_services/AttributeAccessor.h

examples/common/pigweed/rpc_services/AccessInterceptor.h

examples/common/pigweed/rpc_services/AccessInterceptorRegistry.h

examples/common/pigweed/rpc_services/Attributes.h

Nit : rename parameter names. Co-authored-by: Andrei Litvin <[email protected]>

Review suggestion. Co-authored-by: Andrei Litvin <[email protected]>

github-actions · 2025-02-06T20:11:49Z

PR #37351: Size comparison from 2cf6dd8 to 7676386

Full report (3 builds for cc32xx, stm32)

platform	target	config	section	`2cf6dd8`	`7676386`
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	538621	538621
			RAM	205208	205208
	lock	CC3235SF_LAUNCHXL	FLASH	572493	572493
			RAM	205360	205360
stm32	light	STM32WB5MM-DK	FLASH	482872	482872
			RAM	144688	144688

github-actions · 2025-02-06T20:51:33Z

PR #37351: Size comparison from 8f28a21 to 40de86d

Full report (3 builds for cc32xx, stm32)

platform	target	config	section	`8f28a21`	`40de86d`
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	538621	538621
			RAM	205208	205208
	lock	CC3235SF_LAUNCHXL	FLASH	572493	572493
			RAM	205360	205360
stm32	light	STM32WB5MM-DK	FLASH	482872	482872
			RAM	144688	144688

examples/common/pigweed/rpc_services/AccessInterceptor.h

github-actions · 2025-02-06T21:00:31Z

PR #37351: Size comparison from 8f28a21 to ba38ab0

Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)

platform	target	config	section	`8f28a21`	`ba38ab0`	change	% change
bl602	lighting-app	bl602+mfd+littlefs+rpc	FLASH	`1094024`	1094720	696	0.1
			RAM	103314	103346	32	0.0
bl702	lighting-app	bl702+eth	FLASH	650542	650542	0	0.0
			RAM	25265	25265	0	0.0
		bl702+wifi	FLASH	828506	828506	0	0.0
			RAM	13981	13981	0	0.0
		bl706+mfd+rpc+littlefs	FLASH	1057066	1057758	692	0.1
			RAM	23861	23893	32	0.1
bl702l	contact-sensor-app	bl702l+mfd+littlefs	FLASH	888444	888444	0	0.0
			RAM	18504	18504	0	0.0
	lighting-app	bl702l+mfd+littlefs	FLASH	971486	971486	0	0.0
			RAM	16368	16368	0	0.0
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	838240	838240	0	0.0
			RAM	123480	123480	0	0.0
	lock-ftd	LP_EM_CC1354P10_6	FLASH	823644	823644	0	0.0
			RAM	125360	125360	0	0.0
	pump-app	LP_EM_CC1354P10_6	FLASH	770820	770820	0	0.0
			RAM	113820	113820	0	0.0
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	755088	755088	0	0.0
			RAM	114028	114028	0	0.0
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	538621	538621	0	0.0
			RAM	205208	205208	0	0.0
	lock	CC3235SF_LAUNCHXL	FLASH	572493	572493	0	0.0
			RAM	205360	205360	0	0.0
cyw30739	light	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	679585	679585	0	0.0
			RAM	78548	78548	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	699429	699429	0	0.0
			RAM	81188	81188	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	699429	699429	0	0.0
			RAM	81188	81188	0	0.0
		CYW930739M2EVB-02	unknown	2040	2040	0	0.0
			FLASH	656365	656365	0	0.0
			RAM	73616	73616	0	0.0
	light-switch	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	615945	615945	0	0.0
			RAM	71532	71532	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	635573	635573	0	0.0
			RAM	74076	74076	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	635573	635573	0	0.0
			RAM	74076	74076	0	0.0
	lock	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	635449	635449	0	0.0
			RAM	74540	74540	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	655157	655157	0	0.0
			RAM	77084	77084	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	655157	655157	0	0.0
			RAM	77084	77084	0	0.0
	thermostat	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	611861	611861	0	0.0
			RAM	68628	68628	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	631721	631721	0	0.0
			RAM	71268	71268	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	631721	631721	0	0.0
			RAM	71268	71268	0	0.0
efr32	lock-app	BRD4187C	FLASH	936408	937056	648	0.1
			RAM	159872	159904	32	0.0
		BRD4338a	FLASH	730348	730348	0	0.0
			RAM	234716	234716	0	0.0
	window-app	BRD4187C	FLASH	`1029656`	`1029656`	0	0.0
			RAM	128008	128008	0	0.0
esp32	all-clusters-app	c3devkit	DRAM	97312	97312	0	0.0
			FLASH	`1577420`	`1577420`	0	0.0
			IRAM	83820	83820	0	0.0
		m5stack	DRAM	116100	116100	0	0.0
			FLASH	1545326	1545326	0	0.0
			IRAM	117039	117039	0	0.0
linux	air-purifier-app	debug	unknown	4760	4760	0	0.0
			FLASH	2709171	2709171	0	0.0
			RAM	132784	132784	0	0.0
	all-clusters-app	debug	unknown	5568	5568	0	0.0
			FLASH	5975584	5975584	0	0.0
			RAM	531600	531600	0	0.0
	all-clusters-minimal-app	debug	unknown	5464	5464	0	0.0
			FLASH	5323948	5323948	0	0.0
			RAM	242712	242712	0	0.0
	bridge-app	debug	unknown	5480	5480	0	0.0
			FLASH	4682560	4682560	0	0.0
			RAM	221448	221448	0	0.0
	chip-tool	debug	unknown	6120	6120	0	0.0
			FLASH	13099268	13099268	0	0.0
			RAM	596578	596578	0	0.0
	chip-tool-ipv6only	arm64	unknown	21816	21816	0	0.0
			FLASH	11162800	11162800	0	0.0
			RAM	648256	648256	0	0.0
	fabric-admin	debug	unknown	5808	5808	0	0.0
			FLASH	11388297	11388297	0	0.0
			RAM	596362	596362	0	0.0
	fabric-bridge-app	debug	unknown	4736	4736	0	0.0
			FLASH	`4507818`	`4507818`	0	0.0
			RAM	208632	208632	0	0.0
	fabric-sync	debug	unknown	4976	4976	0	0.0
			FLASH	5614085	5614085	0	0.0
			RAM	483504	483504	0	0.0
	lighting-app	debug+rpc+ui	unknown	6144	6144	0	0.0
			FLASH	`5625217`	5629809	4592	0.1
			RAM	231728	231792	64	0.0
	lock-app	debug	unknown	5416	5416	0	0.0
			FLASH	4731186	4731186	0	0.0
			RAM	207696	207696	0	0.0
	ota-provider-app	debug	unknown	4776	4776	0	0.0
			FLASH	4360136	4360136	0	0.0
			RAM	201336	201336	0	0.0
	ota-requestor-app	debug	unknown	4728	4728	0	0.0
			FLASH	4497640	4497640	0	0.0
			RAM	205920	205920	0	0.0
	shell	debug	unknown	4256	4256	0	0.0
			FLASH	3005709	3005709	0	0.0
			RAM	160472	160472	0	0.0
	thermostat-no-ble	arm64	unknown	9512	9512	0	0.0
			FLASH	`4097192`	`4097192`	0	0.0
			RAM	246024	246024	0	0.0
	tv-app	debug	unknown	5744	5744	0	0.0
			FLASH	5952965	5952965	0	0.0
			RAM	606904	606904	0	0.0
	tv-casting-app	debug	unknown	5320	5320	0	0.0
			FLASH	11272797	11272797	0	0.0
			RAM	710864	710864	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	907432	907432	0	0.0
			RAM	142411	142411	0	0.0
		nrf7002dk_nrf5340_cpuapp	FLASH	901980	901980	0	0.0
			RAM	124755	124755	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	846040	846040	0	0.0
			RAM	141339	141339	0	0.0
nxp	contact	k32w0+release	FLASH	584624	584624	0	0.0
			RAM	70876	70876	0	0.0
		mcxw71+release	FLASH	599936	599936	0	0.0
			RAM	63096	63096	0	0.0
	light	k32w0+release	FLASH	610932	610932	0	0.0
			RAM	70268	70268	0	0.0
		k32w1+release	FLASH	685336	685336	0	0.0
			RAM	48680	48680	0	0.0
	lock	mcxw71+release	FLASH	748832	748832	0	0.0
			RAM	67492	67492	0	0.0
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1646740	1646740	0	0.0
			RAM	211576	211576	0	0.0
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	1553628	1553628	0	0.0
			RAM	208392	208392	0	0.0
	light	cy8ckit_062s2_43012	FLASH	1469356	1469356	0	0.0
			RAM	200368	200368	0	0.0
	lock	cy8ckit_062s2_43012	FLASH	1467308	1467308	0	0.0
			RAM	224704	224704	0	0.0
qpg	lighting-app	qpg6105+debug	FLASH	662216	662216	0	0.0
			RAM	105220	105220	0	0.0
	lock-app	qpg6105+debug	FLASH	619996	619996	0	0.0
			RAM	99664	99664	0	0.0
stm32	light	STM32WB5MM-DK	FLASH	482872	482872	0	0.0
			RAM	144688	144688	0	0.0
telink	bridge-app	tl7218x	FLASH	665258	665258	0	0.0
			RAM	90828	90828	0	0.0
	contact-sensor-app	tlsr9528a_retention	FLASH	622020	622020	0	0.0
			RAM	31500	31500	0	0.0
	light-app-ota-shell-factory-data	tl3218x	FLASH	770804	770804	0	0.0
			RAM	43568	43568	0	0.0
		tl7218x	FLASH	779306	779306	0	0.0
			RAM	98704	98704	0	0.0
	light-switch-app-ota-compress-lzma-factory-data	tl7218x_retention	FLASH	680618	680618	0	0.0
			RAM	52192	52192	0	0.0
	light-switch-app-ota-compress-lzma-shell-factory-data	tlsr9528a	FLASH	709172	709172	0	0.0
			RAM	73400	73400	0	0.0
	lighting-app-ota-factory-data	tlsr9118bdk40d	FLASH	626108	626108	0	0.0
			RAM	142032	142032	0	0.0
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	FLASH	813492	813952	460	0.1
			RAM	99576	99608	32	0.0
tizen	all-clusters-app	arm	unknown	5104	5104	0	0.0
			FLASH	1752232	1752232	0	0.0
			RAM	93508	93508	0	0.0
	chip-tool-ubsan	arm	unknown	11396	11396	0	0.0
			FLASH	18696694	18696694	0	0.0
			RAM	8182536	8182536	0	0.0

github-actions · 2025-02-06T22:33:02Z

PR #37351: Size comparison from 2a15d46 to 20294c9

Full report (16 builds for bl602, bl702, bl702l, cc32xx, nrfconnect, qpg, stm32, tizen)

platform	target	config	section	`2a15d46`	`20294c9`	change	% change
bl602	lighting-app	bl602+mfd+littlefs+rpc	FLASH	1094146	1094842	696	0.1
			RAM	103314	103346	32	0.0
bl702	lighting-app	bl702+eth	FLASH	650664	650664	0	0.0
			RAM	25265	25265	0	0.0
		bl702+wifi	FLASH	828628	828628	0	0.0
			RAM	13981	13981	0	0.0
		bl706+mfd+rpc+littlefs	FLASH	1057188	1057880	692	0.1
			RAM	23861	23893	32	0.1
bl702l	contact-sensor-app	bl702l+mfd+littlefs	FLASH	888566	888566	0	0.0
			RAM	18504	18504	0	0.0
	lighting-app	bl702l+mfd+littlefs	FLASH	971608	971608	0	0.0
			RAM	16368	16368	0	0.0
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	538925	538925	0	0.0
			RAM	205208	205208	0	0.0
	lock	CC3235SF_LAUNCHXL	FLASH	572805	572805	0	0.0
			RAM	205360	205360	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	907584	907584	0	0.0
			RAM	142411	142411	0	0.0
		nrf7002dk_nrf5340_cpuapp	FLASH	902100	902100	0	0.0
			RAM	124755	124755	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	846188	846188	0	0.0
			RAM	141339	141339	0	0.0
qpg	lighting-app	qpg6105+debug	FLASH	662360	662360	0	0.0
			RAM	105220	105220	0	0.0
	lock-app	qpg6105+debug	FLASH	620148	620148	0	0.0
			RAM	99664	99664	0	0.0
stm32	light	STM32WB5MM-DK	FLASH	483016	483016	0	0.0
			RAM	144688	144688	0	0.0
tizen	all-clusters-app	arm	unknown	5104	5104	0	0.0
			FLASH	1752644	1752644	0	0.0
			RAM	93508	93508	0	0.0
	chip-tool-ubsan	arm	unknown	11396	11396	0	0.0
			FLASH	18698558	18698558	0	0.0
			RAM	8183320	8183320	0	0.0

github-actions · 2025-02-06T23:24:50Z

PR #37351: Size comparison from 93114c7 to cbcbae7

Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)

platform	target	config	section	`93114c7`	`cbcbae7`	change	% change
bl602	lighting-app	bl602+mfd+littlefs+rpc	FLASH	1094146	1094842	696	0.1
			RAM	103314	103346	32	0.0
bl702	lighting-app	bl702+eth	FLASH	650664	650664	0	0.0
			RAM	25265	25265	0	0.0
		bl702+wifi	FLASH	828628	828628	0	0.0
			RAM	13981	13981	0	0.0
		bl706+mfd+rpc+littlefs	FLASH	1057188	1057880	692	0.1
			RAM	23861	23893	32	0.1
bl702l	contact-sensor-app	bl702l+mfd+littlefs	FLASH	888566	888566	0	0.0
			RAM	18504	18504	0	0.0
	lighting-app	bl702l+mfd+littlefs	FLASH	971608	971608	0	0.0
			RAM	16368	16368	0	0.0
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	838552	838552	0	0.0
			RAM	123480	123480	0	0.0
	lock-ftd	LP_EM_CC1354P10_6	FLASH	823956	823956	0	0.0
			RAM	125360	125360	0	0.0
	pump-app	LP_EM_CC1354P10_6	FLASH	771132	771132	0	0.0
			RAM	113820	113820	0	0.0
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	755400	755400	0	0.0
			RAM	114028	114028	0	0.0
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	538925	538925	0	0.0
			RAM	205208	205208	0	0.0
	lock	CC3235SF_LAUNCHXL	FLASH	572805	572805	0	0.0
			RAM	205360	205360	0	0.0
cyw30739	light	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	679897	679897	0	0.0
			RAM	78548	78548	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	699741	699741	0	0.0
			RAM	81188	81188	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	699741	699741	0	0.0
			RAM	81188	81188	0	0.0
		CYW930739M2EVB-02	unknown	2040	2040	0	0.0
			FLASH	656677	656677	0	0.0
			RAM	73616	73616	0	0.0
	light-switch	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	616241	616241	0	0.0
			RAM	71532	71532	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	635869	635869	0	0.0
			RAM	74076	74076	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	635869	635869	0	0.0
			RAM	74076	74076	0	0.0
	lock	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	635745	635745	0	0.0
			RAM	74540	74540	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	655453	655453	0	0.0
			RAM	77084	77084	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	655453	655453	0	0.0
			RAM	77084	77084	0	0.0
	thermostat	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	612165	612165	0	0.0
			RAM	68628	68628	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	632025	632025	0	0.0
			RAM	71268	71268	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	632025	632025	0	0.0
			RAM	71268	71268	0	0.0
efr32	lock-app	BRD4187C	FLASH	936568	937216	648	0.1
			RAM	159872	159904	32	0.0
		BRD4338a	FLASH	730596	730596	0	0.0
			RAM	234716	234716	0	0.0
	window-app	BRD4187C	FLASH	`1029904`	`1029904`	0	0.0
			RAM	128008	128008	0	0.0
esp32	all-clusters-app	c3devkit	DRAM	97312	97312	0	0.0
			FLASH	`1577574`	`1577574`	0	0.0
			IRAM	83820	83820	0	0.0
		m5stack	DRAM	116100	116100	0	0.0
			FLASH	`1545434`	`1545434`	0	0.0
			IRAM	117039	117039	0	0.0
linux	air-purifier-app	debug	unknown	4760	4760	0	0.0
			FLASH	`2709805`	`2709805`	0	0.0
			RAM	132784	132784	0	0.0
	all-clusters-app	debug	unknown	5568	5568	0	0.0
			FLASH	5976248	5976248	0	0.0
			RAM	531600	531600	0	0.0
	all-clusters-minimal-app	debug	unknown	5464	5464	0	0.0
			FLASH	`5324612`	`5324612`	0	0.0
			RAM	242712	242712	0	0.0
	bridge-app	debug	unknown	5480	5480	0	0.0
			FLASH	4683224	4683224	0	0.0
			RAM	221448	221448	0	0.0
	chip-tool	debug	unknown	6120	6120	0	0.0
			FLASH	13099932	13099932	0	0.0
			RAM	596578	596578	0	0.0
	chip-tool-ipv6only	arm64	unknown	21816	21816	0	0.0
			FLASH	11163328	11163328	0	0.0
			RAM	648256	648256	0	0.0
	fabric-admin	debug	unknown	5808	5808	0	0.0
			FLASH	11388961	11388961	0	0.0
			RAM	596362	596362	0	0.0
	fabric-bridge-app	debug	unknown	4736	4736	0	0.0
			FLASH	4508482	4508482	0	0.0
			RAM	208632	208632	0	0.0
	fabric-sync	debug	unknown	4976	4976	0	0.0
			FLASH	`5614757`	`5614757`	0	0.0
			RAM	483504	483504	0	0.0
	lighting-app	debug+rpc+ui	unknown	6144	6144	0	0.0
			FLASH	5625889	5630465	4576	0.1
			RAM	231728	231792	64	0.0
	lock-app	debug	unknown	5416	5416	0	0.0
			FLASH	4731818	4731818	0	0.0
			RAM	207696	207696	0	0.0
	ota-provider-app	debug	unknown	4776	4776	0	0.0
			FLASH	`4360768`	`4360768`	0	0.0
			RAM	201336	201336	0	0.0
	ota-requestor-app	debug	unknown	4728	4728	0	0.0
			FLASH	4498304	4498304	0	0.0
			RAM	205920	205920	0	0.0
	shell	debug	unknown	4256	4256	0	0.0
			FLASH	3006445	3006445	0	0.0
			RAM	160472	160472	0	0.0
	thermostat-no-ble	arm64	unknown	9512	9512	0	0.0
			FLASH	4097736	4097736	0	0.0
			RAM	246024	246024	0	0.0
	tv-app	debug	unknown	5744	5744	0	0.0
			FLASH	5953637	5953637	0	0.0
			RAM	606904	606904	0	0.0
	tv-casting-app	debug	unknown	5320	5320	0	0.0
			FLASH	11273469	11273469	0	0.0
			RAM	710864	710864	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	907584	907584	0	0.0
			RAM	142411	142411	0	0.0
		nrf7002dk_nrf5340_cpuapp	FLASH	902100	902100	0	0.0
			RAM	124755	124755	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	846188	846188	0	0.0
			RAM	141339	141339	0	0.0
nxp	contact	k32w0+release	FLASH	584768	584768	0	0.0
			RAM	70876	70876	0	0.0
		mcxw71+release	FLASH	600232	600232	0	0.0
			RAM	63096	63096	0	0.0
	light	k32w0+release	FLASH	611076	611076	0	0.0
			RAM	70268	70268	0	0.0
		k32w1+release	FLASH	685640	685640	0	0.0
			RAM	48680	48680	0	0.0
	lock	mcxw71+release	FLASH	749128	749128	0	0.0
			RAM	67492	67492	0	0.0
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1646972	1646972	0	0.0
			RAM	211576	211576	0	0.0
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	1553876	1553876	0	0.0
			RAM	208392	208392	0	0.0
	light	cy8ckit_062s2_43012	FLASH	`1469604`	`1469604`	0	0.0
			RAM	200368	200368	0	0.0
	lock	cy8ckit_062s2_43012	FLASH	1467540	1467540	0	0.0
			RAM	224704	224704	0	0.0
qpg	lighting-app	qpg6105+debug	FLASH	662360	662360	0	0.0
			RAM	105220	105220	0	0.0
	lock-app	qpg6105+debug	FLASH	620148	620148	0	0.0
			RAM	99664	99664	0	0.0
stm32	light	STM32WB5MM-DK	FLASH	483016	483016	0	0.0
			RAM	144688	144688	0	0.0
telink	bridge-app	tl7218x	FLASH	665410	665410	0	0.0
			RAM	90828	90828	0	0.0
	contact-sensor-app	tlsr9528a_retention	FLASH	622172	622172	0	0.0
			RAM	31500	31500	0	0.0
	light-app-ota-shell-factory-data	tl3218x	FLASH	770956	770956	0	0.0
			RAM	43568	43568	0	0.0
		tl7218x	FLASH	779458	779458	0	0.0
			RAM	98704	98704	0	0.0
	light-switch-app-ota-compress-lzma-factory-data	tl7218x_retention	FLASH	680770	680770	0	0.0
			RAM	52192	52192	0	0.0
	light-switch-app-ota-compress-lzma-shell-factory-data	tlsr9528a	FLASH	709324	709324	0	0.0
			RAM	73400	73400	0	0.0
	lighting-app-ota-factory-data	tlsr9118bdk40d	FLASH	626260	626260	0	0.0
			RAM	142032	142032	0	0.0
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	FLASH	813644	814104	460	0.1
			RAM	99576	99608	32	0.0
tizen	all-clusters-app	arm	unknown	5104	5104	0	0.0
			FLASH	1752644	1752644	0	0.0
			RAM	93508	93508	0	0.0
	chip-tool-ubsan	arm	unknown	11396	11396	0	0.0
			FLASH	18698558	18698558	0	0.0
			RAM	8183320	8183320	0	0.0

sxb427 added 7 commits February 1, 2025 23:25

Allow custom AAI registration for PwRPC Reads/Writes. Update PwRPC Wr…

2376709

…ites to look for custom AAIs before using datamodel provider

Add succes log

209f816

Make TryWriteViaAAI public

5a361ca

Make TryWriteViaAAI public

5457062

Fix compilation errors

008f9bf

Fix compilation errors

f606f4b

Fix compilation errors

a130e5f

pullapprove bot added the review - pending label Feb 2, 2025

github-actions bot added the examples label Feb 2, 2025

tcarmelveilleux reviewed Feb 3, 2025

View reviewed changes

examples/common/pigweed/rpc_services/Attributes.h Outdated Show resolved Hide resolved

tcarmelveilleux reviewed Feb 3, 2025

View reviewed changes

src/data-model-providers/codegen/CodegenDataModelProvider.h Outdated Show resolved Hide resolved

tcarmelveilleux reviewed Feb 3, 2025

View reviewed changes

examples/common/pigweed/rpc_services/Attributes.h Outdated Show resolved Hide resolved

tcarmelveilleux reviewed Feb 3, 2025

View reviewed changes

examples/common/pigweed/rpc_services/Attributes.h Outdated Show resolved Hide resolved

tcarmelveilleux reviewed Feb 3, 2025

View reviewed changes

examples/common/pigweed/rpc_services/Attributes.h Outdated Show resolved Hide resolved

andy31415 requested changes Feb 3, 2025

View reviewed changes

Update examples/common/pigweed/rpc_services/Attributes.h

4393084

Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>

sxb427 added 4 commits February 3, 2025 18:43

Add new attribute accessor and registry for PwRPC

5fe8146

Fix compilation error

38feaad

Fix compilation error

0bb1c43

Fix compilation error

a8bcf87

sxb427 added 2 commits February 3, 2025 22:17

Revert changes

e5c8e4b

Revert changes

95c1d6b

sxb427 requested review from andy31415 and tcarmelveilleux February 4, 2025 06:31

tcarmelveilleux reviewed Feb 4, 2025

View reviewed changes

examples/common/pigweed/rpc_services/AttributeAccessor.h Outdated Show resolved Hide resolved

andy31415 reviewed Feb 6, 2025

View reviewed changes

examples/common/pigweed/rpc_services/AccessInterceptor.h Outdated Show resolved Hide resolved

andy31415 reviewed Feb 6, 2025

View reviewed changes

examples/common/pigweed/rpc_services/AccessInterceptor.h Outdated Show resolved Hide resolved

andy31415 reviewed Feb 6, 2025

View reviewed changes

examples/common/pigweed/rpc_services/AccessInterceptor.h Outdated Show resolved Hide resolved

andy31415 reviewed Feb 6, 2025

View reviewed changes

examples/common/pigweed/rpc_services/AccessInterceptor.h Outdated Show resolved Hide resolved

andy31415 reviewed Feb 6, 2025

View reviewed changes

examples/common/pigweed/rpc_services/AccessInterceptor.h Outdated Show resolved Hide resolved

andy31415 reviewed Feb 6, 2025

View reviewed changes

examples/common/pigweed/rpc_services/AccessInterceptorRegistry.h Outdated Show resolved Hide resolved

andy31415 reviewed Feb 6, 2025

View reviewed changes

examples/common/pigweed/rpc_services/AccessInterceptorRegistry.h Outdated Show resolved Hide resolved

andy31415 reviewed Feb 6, 2025

View reviewed changes

examples/common/pigweed/rpc_services/AccessInterceptorRegistry.h Outdated Show resolved Hide resolved

andy31415 reviewed Feb 6, 2025

View reviewed changes

examples/common/pigweed/rpc_services/AccessInterceptorRegistry.h Outdated Show resolved Hide resolved

andy31415 reviewed Feb 6, 2025

View reviewed changes

examples/common/pigweed/rpc_services/AccessInterceptorRegistry.h Outdated Show resolved Hide resolved

andy31415 reviewed Feb 6, 2025

View reviewed changes

examples/common/pigweed/rpc_services/Attributes.h Show resolved Hide resolved

andy31415 reviewed Feb 6, 2025

View reviewed changes

examples/common/pigweed/rpc_services/Attributes.h Outdated Show resolved Hide resolved

sxb427 and others added 4 commits February 6, 2025 11:35

Update examples/common/pigweed/rpc_services/AccessInterceptor.h

222ab01

Nit : rename parameter names. Co-authored-by: Andrei Litvin <[email protected]>

Update examples/common/pigweed/rpc_services/AccessInterceptor.h

a3e8f15

Review suggestion. Co-authored-by: Andrei Litvin <[email protected]>

Update examples/common/pigweed/rpc_services/AccessInterceptorRegistry.h

45f54b8

Review suggestion. Co-authored-by: Andrei Litvin <[email protected]>

Merge branch 'master' into pwrpc-aai

7676386

sxb427 added 2 commits February 6, 2025 12:27

Review comments

38edc19

Merge branch 'master' into pwrpc-aai

40de86d

andy31415 reviewed Feb 6, 2025

View reviewed changes

examples/common/pigweed/rpc_services/AccessInterceptor.h Outdated Show resolved Hide resolved

Update examples/common/pigweed/rpc_services/AccessInterceptor.h

ba38ab0

andy31415 approved these changes Feb 6, 2025

View reviewed changes

andy31415 added the fast track label Feb 6, 2025

Merge branch 'master' into pwrpc-aai

20294c9

Merge branch 'master' into pwrpc-aai

cbcbae7

mergify bot merged commit ce47e22 into project-chip:master Feb 7, 2025
70 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create an AAI registry for PwRPC services to allow registration of custom AAI classes #37351

Create an AAI registry for PwRPC services to allow registration of custom AAI classes #37351

sxb427 commented Feb 2, 2025 •

edited

Loading

semanticdiff-com bot commented Feb 2, 2025

github-actions bot commented Feb 2, 2025 •

edited

Loading

andy31415 left a comment

github-actions bot commented Feb 3, 2025 •

edited

Loading

github-actions bot commented Feb 4, 2025 •

edited

Loading

github-actions bot commented Feb 4, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025

github-actions bot commented Feb 6, 2025

github-actions bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

Create an AAI registry for PwRPC services to allow registration of custom AAI classes #37351

Create an AAI registry for PwRPC services to allow registration of custom AAI classes #37351

Conversation

sxb427 commented Feb 2, 2025 • edited Loading

Testing

Testing backwards compatibility

semanticdiff-com bot commented Feb 2, 2025

github-actions bot commented Feb 2, 2025 • edited Loading

andy31415 left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 3, 2025 • edited Loading

github-actions bot commented Feb 4, 2025 • edited Loading

github-actions bot commented Feb 4, 2025 • edited Loading

github-actions bot commented Feb 6, 2025

github-actions bot commented Feb 6, 2025

github-actions bot commented Feb 6, 2025 • edited Loading

github-actions bot commented Feb 6, 2025 • edited Loading

github-actions bot commented Feb 6, 2025 • edited Loading

sxb427 commented Feb 2, 2025 •

edited

Loading

github-actions bot commented Feb 2, 2025 •

edited

Loading

github-actions bot commented Feb 3, 2025 •

edited

Loading

github-actions bot commented Feb 4, 2025 •

edited

Loading

github-actions bot commented Feb 4, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading