Reduce logging in BDXTransferSession by removing logging for BlockQue… #37412
+20
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
nivi-apple
force-pushed
the
reduce_bdx_block_messages
branch
from
9186350 to
57a4bc9
Compare
…ry, Block and BlockAck messages as they generate a lot of logs - The Exchange Manager alreadys logs the BlockQuery, Block and BlockAck messages and that can be used for debugging purposes - Do not log messages for OutputEvent when the event type is None - Also reduce additional logging in the darwin code.
nivi-apple
force-pushed
the
reduce_bdx_block_messages
branch
from
57a4bc9 to
d54b011
Compare
woody-apple
approved these changes
Feb 5, 2025
andy31415
reviewed
Feb 5, 2025
nivi-apple
force-pushed
the
reduce_bdx_block_messages
branch
from
257be6e to
2779683
Compare
|
PR #37412: Size comparison from cf68487 to 2779683 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Feb 6, 2025
|
PR #37412: Size comparison from cf68487 to f1a1ac3 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ry, Block and BlockAck messages as they generate a lot of logs
The Exchange Manager alreadys logs the BlockQuery, Block and BlockAck messages and that can be used for debugging purposes
Also reduce additional logging in the darwin code.
Fixes: #37411
Testing
Ran MTROTAProviderTests to verify all tests pass.