[CASESession] Follow up to refactoring Sigma Parsing functions PR #37425

Alami-Amine · 2025-02-06T11:56:12Z

Follow-up to [CASESession] Factoring Out Sigma2 and Sigma3 Parsing Functions for Improved Testability #36941 based on comments

Changes in the PR

Make ConstructTBSData() pass a MutableByteSpan as outparam instead of a Pointer and length variable; particularly relevant since the Length variable will be mutated.
Adding a msgR2Decrypted struct member to hold the decrypted msgR2Encrypted payload.
Improve Logging when we assign PeerSessionID --> Added the PeerNodeID when possible
Remove TODO comment suggesting that validating signature before validating operational credentials could prevent a possible DoS attack.

Comment references

          If we passed a mutable span instead to the ConstructTBSData, then it may be clearer that it's a max length in msgR3SignedLen?

Originally posted by @tcarmelveilleux in #36941 (comment)

          Here's a question: how would you feel about having msgR2Encrypted and msgR2Decrypted members, which are mutually exclusive, and std::move from one to the other after successfuly decrypt?  These structs only live on the stack, and in practice it would just be a small number of extra bytes in the struct, but might help clarity?

Originally posted by @bzbarsky-apple in #36941 (comment)

          Pre-existing, but this is kind of a useless log, because it does not say _which peer_.  Followup, perhaps, to add that information?

Originally posted by @bzbarsky-apple in #36941 (comment)

Testing

CI Testing

… + Len

semanticdiff-com · 2025-02-06T11:56:18Z

Review changes with

github-actions · 2025-02-06T12:11:32Z

PR #37425: Size comparison from a998bf6 to df17402

Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)

platform	target	config	section	`a998bf6`	`df17402`	change
bl602	lighting-app	bl602+mfd+littlefs+rpc	FLASH	`1094024`	1094146	122
			RAM	103314	103314	0
bl702	lighting-app	bl702+eth	FLASH	650542	650664	122
			RAM	25265	25265	0
		bl702+wifi	FLASH	828506	828628	122
			RAM	13981	13981	0
		bl706+mfd+rpc+littlefs	FLASH	1057066	1057188	122
			RAM	23861	23861	0
bl702l	contact-sensor-app	bl702l+mfd+littlefs	FLASH	888444	888566	122
			RAM	18504	18504	0
	lighting-app	bl702l+mfd+littlefs	FLASH	971486	971608	122
			RAM	16368	16368	0
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	838240	838488	248
			RAM	123480	123480	0
	lock-ftd	LP_EM_CC1354P10_6	FLASH	823644	823892	248
			RAM	125360	125360	0
	pump-app	LP_EM_CC1354P10_6	FLASH	770820	771068	248
			RAM	113820	113820	0
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	755088	755336	248
			RAM	114028	114028	0
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	538621	538861	240
			RAM	205208	205208	0
	lock	CC3235SF_LAUNCHXL	FLASH	572493	572741	248
			RAM	205360	205360	0
cyw30739	light	CYW30739B2-P5-EVK-01	unknown	2040	2040	0
			FLASH	679585	679833	248
			RAM	78548	78548	0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0
			FLASH	699429	699677	248
			RAM	81188	81188	0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0
			FLASH	699429	699677	248
			RAM	81188	81188	0
		CYW930739M2EVB-02	unknown	2040	2040	0
			FLASH	656365	656613	248
			RAM	73616	73616	0
	light-switch	CYW30739B2-P5-EVK-01	unknown	2040	2040	0
			FLASH	615945	616185	240
			RAM	71532	71532	0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0
			FLASH	635573	635813	240
			RAM	74076	74076	0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0
			FLASH	635573	635813	240
			RAM	74076	74076	0
	lock	CYW30739B2-P5-EVK-01	unknown	2040	2040	0
			FLASH	635449	635689	240
			RAM	74540	74540	0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0
			FLASH	655157	655397	240
			RAM	77084	77084	0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0
			FLASH	655157	655397	240
			RAM	77084	77084	0
	thermostat	CYW30739B2-P5-EVK-01	unknown	2040	2040	0
			FLASH	611861	612109	248
			RAM	68628	68628	0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0
			FLASH	631721	631969	248
			RAM	71268	71268	0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0
			FLASH	631721	631969	248
			RAM	71268	71268	0
efr32	lock-app	BRD4187C	FLASH	936408	936568	160
			RAM	159872	159872	0
		BRD4338a	FLASH	730348	730532	184
			RAM	234716	234716	0
	window-app	BRD4187C	FLASH	`1029656`	`1029856`	200
			RAM	128008	128008	0
esp32	all-clusters-app	c3devkit	DRAM	97312	97312	0
			FLASH	`1577420`	`1577574`	154
			IRAM	83820	83820	0
		m5stack	DRAM	116100	116100	0
			FLASH	1545326	`1545434`	108
			IRAM	117039	117039	0
linux	air-purifier-app	debug	unknown	4760	4760	0
			FLASH	2709171	2709509	338
			RAM	132784	132784	0
	all-clusters-app	debug	unknown	5568	5568	0
			FLASH	5975584	5975952	368
			RAM	531600	531600	0
	all-clusters-minimal-app	debug	unknown	5464	5464	0
			FLASH	5323948	`5324316`	368
			RAM	242712	242712	0
	bridge-app	debug	unknown	5480	5480	0
			FLASH	4682560	4682896	336
			RAM	221448	221448	0
	chip-tool	debug	unknown	6120	6120	0
			FLASH	13099268	13099636	368
			RAM	596578	596578	0
	chip-tool-ipv6only	arm64	unknown	21816	21816	0
			FLASH	11162800	11163040	240
			RAM	648256	648256	0
	fabric-admin	debug	unknown	5808	5808	0
			FLASH	11388297	11388665	368
			RAM	596362	596362	0
	fabric-bridge-app	debug	unknown	4736	4736	0
			FLASH	`4507818`	`4508154`	336
			RAM	208632	208632	0
	fabric-sync	debug	unknown	4976	4976	0
			FLASH	5614085	5614453	368
			RAM	483504	483504	0
	lighting-app	debug+rpc+ui	unknown	6144	6144	0
			FLASH	`5625217`	5625585	368
			RAM	231728	231728	0
	lock-app	debug	unknown	5416	5416	0
			FLASH	4731186	4731522	336
			RAM	207696	207696	0
	ota-provider-app	debug	unknown	4776	4776	0
			FLASH	4360136	4360472	336
			RAM	201336	201336	0
	ota-requestor-app	debug	unknown	4728	4728	0
			FLASH	4497640	`4497976`	336
			RAM	205920	205920	0
	shell	debug	unknown	4256	4256	0
			FLASH	3005709	3006125	416
			RAM	160472	160472	0
	thermostat-no-ble	arm64	unknown	9512	9512	0
			FLASH	`4097192`	4097432	240
			RAM	246024	246024	0
	tv-app	debug	unknown	5744	5744	0
			FLASH	5952965	5953301	336
			RAM	606904	606904	0
	tv-casting-app	debug	unknown	5320	5320	0
			FLASH	11272797	11273165	368
			RAM	710864	710864	0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	907288	907440	152
			RAM	142411	142411	0
		nrf7002dk_nrf5340_cpuapp	FLASH	901980	902100	120
			RAM	124755	124755	0
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	845896	846044	148
			RAM	141339	141339	0
nxp	contact	k32w0+release	FLASH	584624	584768	144
			RAM	70876	70876	0
		mcxw71+release	FLASH	599936	600176	240
			RAM	63096	63096	0
	light	k32w0+release	FLASH	610932	611076	144
			RAM	70268	70268	0
		k32w1+release	FLASH	685336	685584	248
			RAM	48680	48680	0
	lock	mcxw71+release	FLASH	748832	749072	240
			RAM	67492	67492	0
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1646740	1646924	184
			RAM	211576	211576	0
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	1553628	`1553812`	184
			RAM	208392	208392	0
	light	cy8ckit_062s2_43012	FLASH	1469356	1469540	184
			RAM	200368	200368	0
	lock	cy8ckit_062s2_43012	FLASH	1467308	1467492	184
			RAM	224704	224704	0
qpg	lighting-app	qpg6105+debug	FLASH	662216	662360	144
			RAM	105220	105220	0
	lock-app	qpg6105+debug	FLASH	619996	620148	152
			RAM	99664	99664	0
stm32	light	STM32WB5MM-DK	FLASH	482872	483016	144
			RAM	144688	144688	0
telink	bridge-app	tl7218x	FLASH	665258	665410	152
			RAM	90828	90828	0
	contact-sensor-app	tlsr9528a_retention	FLASH	622020	622172	152
			RAM	31500	31500	0
	light-app-ota-shell-factory-data	tl3218x	FLASH	770804	770956	152
			RAM	43568	43568	0
		tl7218x	FLASH	779306	779458	152
			RAM	98704	98704	0
	light-switch-app-ota-compress-lzma-factory-data	tl7218x_retention	FLASH	680618	680770	152
			RAM	52192	52192	0
	light-switch-app-ota-compress-lzma-shell-factory-data	tlsr9528a	FLASH	709172	709324	152
			RAM	73400	73400	0
	lighting-app-ota-factory-data	tlsr9118bdk40d	FLASH	626108	626260	152
			RAM	142032	142032	0
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	FLASH	813492	813644	152
			RAM	99576	99576	0
tizen	all-clusters-app	arm	unknown	5104	5104	0
			FLASH	1752232	`1752480`	248
			RAM	93508	93508	0
	chip-tool-ubsan	arm	unknown	11396	11396	0
			FLASH	18696694	18697246	552
			RAM	8182536	8182896	360

src/protocols/secure_channel/CASESession.cpp

github-actions · 2025-02-06T18:35:36Z

PR #37425: Size comparison from a998bf6 to ba43ac1

Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)

platform	target	config	section	`a998bf6`	`ba43ac1`	change	% change
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	838240	838560	320	0.0
			RAM	123480	123480	0	0.0
	lock-ftd	LP_EM_CC1354P10_6	FLASH	823644	823964	320	0.0
			RAM	125360	125360	0	0.0
	pump-app	LP_EM_CC1354P10_6	FLASH	770820	771140	320	0.0
			RAM	113820	113820	0	0.0
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	755088	755408	320	0.0
			RAM	114028	114028	0	0.0
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	538621	538933	312	0.1
			RAM	205208	205208	0	0.0
	lock	CC3235SF_LAUNCHXL	FLASH	572493	572813	320	0.1
			RAM	205360	205360	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	907288	907584	296	0.0
			RAM	142411	142411	0	0.0
		nrf7002dk_nrf5340_cpuapp	FLASH	901980	902100	120	0.0
			RAM	124755	124755	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	845896	846188	292	0.0
			RAM	141339	141339	0	0.0
qpg	lighting-app	qpg6105+debug	FLASH	662216	662360	144	0.0
			RAM	105220	105220	0	0.0
	lock-app	qpg6105+debug	FLASH	619996	620148	152	0.0
			RAM	99664	99664	0	0.0
stm32	light	STM32WB5MM-DK	FLASH	482872	483016	144	0.0
			RAM	144688	144688	0	0.0
tizen	all-clusters-app	arm	unknown	5104	5104	0	0.0
			FLASH	1752232	1752652	420	0.0
			RAM	93508	93508	0	0.0
	chip-tool-ubsan	arm	unknown	11396	11396	0	0.0
			FLASH	18696694	18698566	1872	0.0
			RAM	8182536	8183320	784	0.0

github-actions · 2025-02-06T19:04:44Z

PR #37425: Size comparison from 35781e5 to 77b82e3

Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)

platform	target	config	section	`35781e5`	`77b82e3`	change	% change
bl602	lighting-app	bl602+mfd+littlefs+rpc	FLASH	`1094024`	1094146	122	0.0
			RAM	103314	103314	0	0.0
bl702	lighting-app	bl702+eth	FLASH	650542	650664	122	0.0
			RAM	25265	25265	0	0.0
		bl702+wifi	FLASH	828506	828628	122	0.0
			RAM	13981	13981	0	0.0
		bl706+mfd+rpc+littlefs	FLASH	1057066	1057188	122	0.0
			RAM	23861	23861	0	0.0
bl702l	contact-sensor-app	bl702l+mfd+littlefs	FLASH	888444	888566	122	0.0
			RAM	18504	18504	0	0.0
	lighting-app	bl702l+mfd+littlefs	FLASH	971486	971608	122	0.0
			RAM	16368	16368	0	0.0
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	838240	838552	312	0.0
			RAM	123480	123480	0	0.0
	lock-ftd	LP_EM_CC1354P10_6	FLASH	823644	823956	312	0.0
			RAM	125360	125360	0	0.0
	pump-app	LP_EM_CC1354P10_6	FLASH	770820	771132	312	0.0
			RAM	113820	113820	0	0.0
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	755088	755400	312	0.0
			RAM	114028	114028	0	0.0
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	538621	538925	304	0.1
			RAM	205208	205208	0	0.0
	lock	CC3235SF_LAUNCHXL	FLASH	572493	572805	312	0.1
			RAM	205360	205360	0	0.0
cyw30739	light	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	679585	679897	312	0.0
			RAM	78548	78548	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	699429	699741	312	0.0
			RAM	81188	81188	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	699429	699741	312	0.0
			RAM	81188	81188	0	0.0
		CYW930739M2EVB-02	unknown	2040	2040	0	0.0
			FLASH	656365	656677	312	0.0
			RAM	73616	73616	0	0.0
	light-switch	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	615945	616241	296	0.0
			RAM	71532	71532	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	635573	635869	296	0.0
			RAM	74076	74076	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	635573	635869	296	0.0
			RAM	74076	74076	0	0.0
	lock	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	635449	635745	296	0.0
			RAM	74540	74540	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	655157	655453	296	0.0
			RAM	77084	77084	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	655157	655453	296	0.0
			RAM	77084	77084	0	0.0
	thermostat	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	611861	612165	304	0.0
			RAM	68628	68628	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	631721	632025	304	0.0
			RAM	71268	71268	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	631721	632025	304	0.0
			RAM	71268	71268	0	0.0
efr32	lock-app	BRD4187C	FLASH	936408	936568	160	0.0
			RAM	159872	159872	0	0.0
		BRD4338a	FLASH	730348	730596	248	0.0
			RAM	234716	234716	0	0.0
	window-app	BRD4187C	FLASH	`1029656`	`1029904`	248	0.0
			RAM	128008	128008	0	0.0
esp32	all-clusters-app	c3devkit	DRAM	97312	97312	0	0.0
			FLASH	`1577420`	`1577574`	154	0.0
			IRAM	83820	83820	0	0.0
		m5stack	DRAM	116100	116100	0	0.0
			FLASH	1545326	`1545434`	108	0.0
			IRAM	117039	117039	0	0.0
linux	air-purifier-app	debug	unknown	4760	4760	0	0.0
			FLASH	2709171	`2709805`	634	0.0
			RAM	132784	132784	0	0.0
	all-clusters-app	debug	unknown	5568	5568	0	0.0
			FLASH	5975584	5976248	664	0.0
			RAM	531600	531600	0	0.0
	all-clusters-minimal-app	debug	unknown	5464	5464	0	0.0
			FLASH	5323948	`5324612`	664	0.0
			RAM	242712	242712	0	0.0
	bridge-app	debug	unknown	5480	5480	0	0.0
			FLASH	4682560	4683224	664	0.0
			RAM	221448	221448	0	0.0
	chip-tool	debug	unknown	6120	6120	0	0.0
			FLASH	13099268	13099932	664	0.0
			RAM	596578	596578	0	0.0
	chip-tool-ipv6only	arm64	unknown	21816	21816	0	0.0
			FLASH	11162800	11163328	528	0.0
			RAM	648256	648256	0	0.0
	fabric-admin	debug	unknown	5808	5808	0	0.0
			FLASH	11388297	11388961	664	0.0
			RAM	596362	596362	0	0.0
	fabric-bridge-app	debug	unknown	4736	4736	0	0.0
			FLASH	`4507818`	4508482	664	0.0
			RAM	208632	208632	0	0.0
	fabric-sync	debug	unknown	4976	4976	0	0.0
			FLASH	5614085	`5614757`	672	0.0
			RAM	483504	483504	0	0.0
	lighting-app	debug+rpc+ui	unknown	6144	6144	0	0.0
			FLASH	`5625217`	5625889	672	0.0
			RAM	231728	231728	0	0.0
	lock-app	debug	unknown	5416	5416	0	0.0
			FLASH	4731186	4731818	632	0.0
			RAM	207696	207696	0	0.0
	ota-provider-app	debug	unknown	4776	4776	0	0.0
			FLASH	4360136	`4360768`	632	0.0
			RAM	201336	201336	0	0.0
	ota-requestor-app	debug	unknown	4728	4728	0	0.0
			FLASH	4497640	4498304	664	0.0
			RAM	205920	205920	0	0.0
	shell	debug	unknown	4256	4256	0	0.0
			FLASH	3005709	3006445	736	0.0
			RAM	160472	160472	0	0.0
	thermostat-no-ble	arm64	unknown	9512	9512	0	0.0
			FLASH	`4097192`	4097736	544	0.0
			RAM	246024	246024	0	0.0
	tv-app	debug	unknown	5744	5744	0	0.0
			FLASH	5952965	5953637	672	0.0
			RAM	606904	606904	0	0.0
	tv-casting-app	debug	unknown	5320	5320	0	0.0
			FLASH	11272797	11273469	672	0.0
			RAM	710864	710864	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	907432	907584	152	0.0
			RAM	142411	142411	0	0.0
		nrf7002dk_nrf5340_cpuapp	FLASH	901980	902100	120	0.0
			RAM	124755	124755	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	846040	846188	148	0.0
			RAM	141339	141339	0	0.0
nxp	contact	k32w0+release	FLASH	584624	584768	144	0.0
			RAM	70876	70876	0	0.0
		mcxw71+release	FLASH	599936	600232	296	0.0
			RAM	63096	63096	0	0.0
	light	k32w0+release	FLASH	610932	611076	144	0.0
			RAM	70268	70268	0	0.0
		k32w1+release	FLASH	685336	685640	304	0.0
			RAM	48680	48680	0	0.0
	lock	mcxw71+release	FLASH	748832	749128	296	0.0
			RAM	67492	67492	0	0.0
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1646740	1646972	232	0.0
			RAM	211576	211576	0	0.0
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	1553628	1553876	248	0.0
			RAM	208392	208392	0	0.0
	light	cy8ckit_062s2_43012	FLASH	1469356	`1469604`	248	0.0
			RAM	200368	200368	0	0.0
	lock	cy8ckit_062s2_43012	FLASH	1467308	1467540	232	0.0
			RAM	224704	224704	0	0.0
qpg	lighting-app	qpg6105+debug	FLASH	662216	662360	144	0.0
			RAM	105220	105220	0	0.0
	lock-app	qpg6105+debug	FLASH	619996	620148	152	0.0
			RAM	99664	99664	0	0.0
stm32	light	STM32WB5MM-DK	FLASH	482872	483016	144	0.0
			RAM	144688	144688	0	0.0
telink	bridge-app	tl7218x	FLASH	665258	665410	152	0.0
			RAM	90828	90828	0	0.0
	contact-sensor-app	tlsr9528a_retention	FLASH	622020	622172	152	0.0
			RAM	31500	31500	0	0.0
	light-app-ota-shell-factory-data	tl3218x	FLASH	770804	770956	152	0.0
			RAM	43568	43568	0	0.0
		tl7218x	FLASH	779306	779458	152	0.0
			RAM	98704	98704	0	0.0
	light-switch-app-ota-compress-lzma-factory-data	tl7218x_retention	FLASH	680618	680770	152	0.0
			RAM	52192	52192	0	0.0
	light-switch-app-ota-compress-lzma-shell-factory-data	tlsr9528a	FLASH	709172	709324	152	0.0
			RAM	73400	73400	0	0.0
	lighting-app-ota-factory-data	tlsr9118bdk40d	FLASH	626108	626260	152	0.0
			RAM	142032	142032	0	0.0
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	FLASH	813492	813644	152	0.0
			RAM	99576	99576	0	0.0
tizen	all-clusters-app	arm	unknown	5104	5104	0	0.0
			FLASH	1752232	1752644	412	0.0
			RAM	93508	93508	0	0.0
	chip-tool-ubsan	arm	unknown	11396	11396	0	0.0
			FLASH	18696694	18698558	1864	0.0
			RAM	8182536	8183320	784	0.0

Alami-Amine added 4 commits February 5, 2025 11:17

Make ConstructTBSData outparam a MutableByteSpan instead of a Pointer…

9318769

… + Len

Adding a msgR2Decrypted struct member to improve clarity

a57bbe8

Clarifying Logs when Assigining Peer SessionID

c0f66a2

Removing TODO on validating signature before validation credentials

df17402

pullapprove bot added the review - pending label Feb 6, 2025

github-actions bot added the protocols label Feb 6, 2025

Alami-Amine commented Feb 6, 2025

View reviewed changes

src/protocols/secure_channel/CASESession.cpp Show resolved Hide resolved

Alami-Amine changed the title ~~Follow up to~~ [CASESession] Follow up to refactoring Sigma Parsing functions PR Feb 6, 2025

andy31415 approved these changes Feb 6, 2025

View reviewed changes

bzbarsky-apple reviewed Feb 6, 2025

View reviewed changes

src/protocols/secure_channel/CASESession.cpp Outdated Show resolved Hide resolved

bzbarsky-apple approved these changes Feb 6, 2025

View reviewed changes

src/protocols/secure_channel/CASESession.cpp Outdated Show resolved Hide resolved

src/protocols/secure_channel/CASESession.cpp Outdated Show resolved Hide resolved

pullapprove bot added review - approved and removed review - pending labels Feb 6, 2025

changing Logs to ScopedNodeID instead of just NodeID

77b82e3

Alami-Amine force-pushed the AA/CASERefactor2Followup branch from ba43ac1 to 77b82e3 Compare February 6, 2025 18:49

mergify bot merged commit 2a15d46 into project-chip:master Feb 6, 2025
70 checks passed

Alami-Amine deleted the AA/CASERefactor2Followup branch February 7, 2025 10:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CASESession] Follow up to refactoring Sigma Parsing functions PR #37425

[CASESession] Follow up to refactoring Sigma Parsing functions PR #37425

Alami-Amine commented Feb 6, 2025 •

edited

Loading

semanticdiff-com bot commented Feb 6, 2025

github-actions bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

[CASESession] Follow up to refactoring Sigma Parsing functions PR #37425

[CASESession] Follow up to refactoring Sigma Parsing functions PR #37425

Conversation

Alami-Amine commented Feb 6, 2025 • edited Loading

Changes in the PR

Comment references

Testing

semanticdiff-com bot commented Feb 6, 2025

github-actions bot commented Feb 6, 2025 • edited Loading

github-actions bot commented Feb 6, 2025 • edited Loading

github-actions bot commented Feb 6, 2025 • edited Loading

Alami-Amine commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading