Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OtaSoftwareUpdate removed from lock-app #37432

Closed
wants to merge 4 commits into from
Closed

OtaSoftwareUpdate removed from lock-app #37432

wants to merge 4 commits into from

Conversation

gd-mauri
Copy link
Contributor

@gd-mauri gd-mauri commented Feb 6, 2025 •
edited
Loading

Removing otaSoftwareUpdate Cluster.

Fix for #37266

Testing

scripts/run_in_python_env.sh out/py './scripts/tests/run_python_test.py --app ./out/darwin-arm64-lock-no-ble/chip-lock-app --app-args "--trace-to json:log" --script src/python_testing/TC_DeviceConformance.py --script-args "--qr-code MT:-24J0AFN00KA0648G00"'

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025 •
edited
Loading

PR #37432: Size comparison from 35781e5 to 8ad153a

Full report (48 builds for bl602, bl702, bl702l, cc32xx, esp32, linux, nrfconnect, nxp, qpg, stm32, telink, tizen)
platform target config section 35781e5 8ad153a change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1094024 1094024 0 0.0
RAM 103314 103314 0 0.0
bl702 lighting-app bl702+eth FLASH 650542 650542 0 0.0
RAM 25265 25265 0 0.0
bl702+wifi FLASH 828506 828506 0 0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057066 1057066 0 0.0
RAM 23861 23861 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888444 888444 0 0.0
RAM 18504 18504 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 971486 971486 0 0.0
RAM 16368 16368 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538621 538621 0 0.0
RAM 205208 205208 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572493 570757 -1736 -0.3
RAM 205360 205328 -32 -0.0
esp32 all-clusters-app c3devkit DRAM 97312 97312 0 0.0
FLASH 1577420 1577420 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116100 116100 0 0.0
FLASH 1545326 1545326 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4760 4760 0 0.0
FLASH 2709171 2709171 0 0.0
RAM 132784 132784 0 0.0
all-clusters-app debug unknown 5568 5568 0 0.0
FLASH 5975584 5975584 0 0.0
RAM 531600 531600 0 0.0
all-clusters-minimal-app debug unknown 5464 5464 0 0.0
FLASH 5323948 5323948 0 0.0
RAM 242712 242712 0 0.0
bridge-app debug unknown 5480 5480 0 0.0
FLASH 4682560 4682560 0 0.0
RAM 221448 221448 0 0.0
chip-tool debug unknown 6120 6120 0 0.0
FLASH 13099268 13099268 0 0.0
RAM 596578 596578 0 0.0
chip-tool-ipv6only arm64 unknown 21816 21816 0 0.0
FLASH 11162800 11162800 0 0.0
RAM 648256 648256 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11388297 11388297 0 0.0
RAM 596362 596362 0 0.0
fabric-bridge-app debug unknown 4736 4736 0 0.0
FLASH 4507818 4507818 0 0.0
RAM 208632 208632 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5614085 5614085 0 0.0
RAM 483504 483504 0 0.0
lighting-app debug+rpc+ui unknown 6144 6144 0 0.0
FLASH 5625217 5625217 0 0.0
RAM 231728 231728 0 0.0
lock-app debug unknown 5416 5416 0 0.0
FLASH 4731186 4718392 -12794 -0.3
RAM 207696 207424 -272 -0.1
ota-provider-app debug unknown 4776 4776 0 0.0
FLASH 4360136 4360136 0 0.0
RAM 201336 201336 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4497640 4497640 0 0.0
RAM 205920 205920 0 0.0
shell debug unknown 4256 4256 0 0.0
FLASH 3005709 3005709 0 0.0
RAM 160472 160472 0 0.0
thermostat-no-ble arm64 unknown 9512 9512 0 0.0
FLASH 4097192 4097192 0 0.0
RAM 246024 246024 0 0.0
tv-app debug unknown 5744 5744 0 0.0
FLASH 5952965 5952965 0 0.0
RAM 606904 606904 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11272797 11272797 0 0.0
RAM 710864 710864 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907432 907432 0 0.0
RAM 142411 142411 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901980 901980 0 0.0
RAM 124755 124755 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846040 846040 0 0.0
RAM 141339 141339 0 0.0
nxp contact k32w0+release FLASH 584624 584624 0 0.0
RAM 70876 70876 0 0.0
mcxw71+release FLASH 599936 599936 0 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 610932 610932 0 0.0
RAM 70268 70268 0 0.0
k32w1+release FLASH 685336 685336 0 0.0
RAM 48680 48680 0 0.0
lock mcxw71+release FLASH 748832 748832 0 0.0
RAM 67492 67492 0 0.0
qpg lighting-app qpg6105+debug FLASH 662216 662216 0 0.0
RAM 105220 105220 0 0.0
lock-app qpg6105+debug FLASH 619996 619996 0 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 482872 482872 0 0.0
RAM 144688 144688 0 0.0
telink bridge-app tl7218x FLASH 665258 665258 0 0.0
RAM 90828 90828 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622020 622020 0 0.0
RAM 31500 31500 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 770804 770804 0 0.0
RAM 43568 43568 0 0.0
tl7218x FLASH 779306 779306 0 0.0
RAM 98704 98704 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680618 680618 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709172 709172 0 0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 626108 626108 0 0.0
RAM 142032 142032 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813492 813492 0 0.0
RAM 99576 99576 0 0.0
tizen all-clusters-app arm unknown 5104 5104 0 0.0
FLASH 1752232 1752232 0 0.0
RAM 93508 93508 0 0.0
chip-tool-ubsan arm unknown 11396 11396 0 0.0
FLASH 18696694 18696694 0 0.0
RAM 8182536 8182536 0 0.0

@gd-mauri gd-mauri changed the title OtaSoftwareUpdate removed from lock-app condition for building test vectors #37266 OtaSoftwareUpdate removed from lock-app #37266 Feb 6, 2025
@gd-mauri gd-mauri changed the title OtaSoftwareUpdate removed from lock-app #37266 OtaSoftwareUpdate removed from lock-app Feb 6, 2025
@gd-mauri gd-mauri mentioned this pull request Feb 6, 2025
Closed
@gd-mauri gd-mauri closed this by deleting the head repository Feb 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025 •
edited
Loading

PR #37432: Size comparison from c02a091 to b667bfd

Full report (48 builds for bl602, bl702, bl702l, cc32xx, esp32, linux, nrfconnect, nxp, qpg, stm32, telink, tizen)
platform target config section c02a091 b667bfd change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1094778 1094778 0 0.0
RAM 103346 103346 0 0.0
bl702 lighting-app bl702+eth FLASH 650600 650600 0 0.0
RAM 25265 25265 0 0.0
bl702+wifi FLASH 828564 828564 0 0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057816 1057816 0 0.0
RAM 23893 23893 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888502 888502 0 0.0
RAM 18504 18504 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 971544 971544 0 0.0
RAM 16368 16368 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538925 538925 0 0.0
RAM 205208 205208 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572805 571069 -1736 -0.3
RAM 205360 205328 -32 -0.0
esp32 all-clusters-app c3devkit DRAM 97312 97312 0 0.0
FLASH 1577574 1577574 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116100 116100 0 0.0
FLASH 1545434 1545434 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4760 4760 0 0.0
FLASH 2709805 2709805 0 0.0
RAM 132784 132784 0 0.0
all-clusters-app debug unknown 5568 5568 0 0.0
FLASH 5976268 5976268 0 0.0
RAM 531600 531600 0 0.0
all-clusters-minimal-app debug unknown 5464 5464 0 0.0
FLASH 5324612 5324612 0 0.0
RAM 242712 242712 0 0.0
bridge-app debug unknown 5480 5480 0 0.0
FLASH 4683224 4683224 0 0.0
RAM 221448 221448 0 0.0
chip-tool debug unknown 6120 6120 0 0.0
FLASH 13099952 13099952 0 0.0
RAM 596578 596578 0 0.0
chip-tool-ipv6only arm64 unknown 21816 21816 0 0.0
FLASH 11163376 11163376 0 0.0
RAM 648256 648256 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11388981 11388981 0 0.0
RAM 596362 596362 0 0.0
fabric-bridge-app debug unknown 4736 4736 0 0.0
FLASH 4508482 4508482 0 0.0
RAM 208632 208632 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5614773 5614773 0 0.0
RAM 483504 483504 0 0.0
lighting-app debug+rpc+ui unknown 6144 6144 0 0.0
FLASH 5630465 5630465 0 0.0
RAM 231792 231792 0 0.0
lock-app debug unknown 5416 5416 0 0.0
FLASH 4731818 4719056 -12762 -0.3
RAM 207696 207424 -272 -0.1
ota-provider-app debug unknown 4776 4776 0 0.0
FLASH 4360788 4360788 0 0.0
RAM 201336 201336 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4498196 4498196 0 0.0
RAM 205920 205920 0 0.0
shell debug unknown 4256 4256 0 0.0
FLASH 3006445 3006445 0 0.0
RAM 160472 160472 0 0.0
thermostat-no-ble arm64 unknown 9512 9512 0 0.0
FLASH 4097736 4097736 0 0.0
RAM 246024 246024 0 0.0
tv-app debug unknown 5744 5744 0 0.0
FLASH 5953653 5953653 0 0.0
RAM 606904 606904 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11273469 11273469 0 0.0
RAM 710864 710864 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907584 907584 0 0.0
RAM 142411 142411 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 902100 902100 0 0.0
RAM 124755 124755 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846188 846188 0 0.0
RAM 141339 141339 0 0.0
nxp contact k32w0+release FLASH 584768 584768 0 0.0
RAM 70876 70876 0 0.0
mcxw71+release FLASH 600232 600232 0 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 611076 611076 0 0.0
RAM 70268 70268 0 0.0
k32w1+release FLASH 685552 685552 0 0.0
RAM 48680 48680 0 0.0
lock mcxw71+release FLASH 749040 749040 0 0.0
RAM 67492 67492 0 0.0
qpg lighting-app qpg6105+debug FLASH 662360 662360 0 0.0
RAM 105220 105220 0 0.0
lock-app qpg6105+debug FLASH 620148 620148 0 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 483016 483016 0 0.0
RAM 144688 144688 0 0.0
telink bridge-app tl7218x FLASH 665410 665410 0 0.0
RAM 90828 90828 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622172 622172 0 0.0
RAM 31500 31500 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 770956 770956 0 0.0
RAM 43568 43568 0 0.0
tl7218x FLASH 779458 779458 0 0.0
RAM 98704 98704 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680770 680770 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709324 709324 0 0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 626260 626260 0 0.0
RAM 142032 142032 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 814104 814104 0 0.0
RAM 99608 99608 0 0.0
tizen all-clusters-app arm unknown 5104 5104 0 0.0
FLASH 1752596 1752596 0 0.0
RAM 93508 93508 0 0.0
chip-tool-ubsan arm unknown 11396 11396 0 0.0
FLASH 18698526 18698526 0 0.0
RAM 8183320 8183320 0 0.0

@gd-mauri gd-mauri mentioned this pull request Feb 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
examples review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gd-mauri