Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Thermostat Controller Device Type #37514

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+28 −0
Open

Add Thermostat Controller Device Type #37514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
089c1b5
Add Thermostat Controller New Device Type
fuxiaoming-lumi Feb 11, 2025
7f18f7b
Rename Matter Thermostat Controller to Thermostat Controller
fuxiaoming-lumi Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/app/zap-templates/zcl/data-model/chip/matter-devices.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2805,4 +2805,28 @@ limitations under the License.
</include>
</clusters>
</deviceType>
<deviceType>
<name>MA-thermostatcontroller</name>
<domain>CHIP</domain>
<typeName>Thermostat Controller</typeName>
<profileId editable="false">0x0103</profileId>
<deviceId editable="false">0x030A</deviceId>
<class>Simple</class>
<scope>Endpoint</scope>
<clusters lockOthers="true">
<include cluster="Descriptor" client="false" server="true" clientLocked="true" serverLocked="true">
<requireAttribute>DEVICE_TYPE_LIST</requireAttribute>
<requireAttribute>SERVER_LIST</requireAttribute>
<requireAttribute>CLIENT_LIST</requireAttribute>
<requireAttribute>PARTS_LIST</requireAttribute>
Comment on lines +2818 to +2821
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this here? Those are required on descriptor always, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I used alchemy to generate it, there were no requireAttribute fields. But I found other device types had these fields like MA-pumpcontroller, so I added them. I can remove them if they are not necessary.

</include>
<include cluster="Binding" client="false" server="true" clientLocked="true" serverLocked="true">
<requireAttribute>BINDING</requireAttribute>
</include>
<include cluster="Thermostat" client="true" server="false" clientLocked="true" serverLocked="true"></include>
<include cluster="Identify" client="true" server="false" clientLocked="false" serverLocked="true"></include>
<include cluster="Groups" client="true" server="false" clientLocked="false" serverLocked="true"></include>
<include cluster="Scenes Management" client="true" server="false" clientLocked="false" serverLocked="true"></include>
</clusters>
</deviceType>
</configurator>
1 change: 1 addition & 0 deletions src/darwin/Framework/CHIP/zap-generated/MTRClusterConstants.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/darwin/Framework/CHIP/zap-generated/MTRDeviceTypeMetadata.mm
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions zzz_generated/chip-tool/zap-generated/cluster/logging/EntryToText.cpp
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading