Make DataModel::Provider return a Complete attribute metadata as its public interface
#37519
+46
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #37519: Size comparison from 63f9782 to 450c980 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
| @@ -277,6 +286,18 @@ CHIP_ERROR CodegenDataModelProvider::Attributes(const ConcreteClusterPath & path | |||
| ReturnErrorOnFailure(builder.Append(AttributeEntryFrom(path, attribute))); | |||
| } | |||
|
|
|||
| DataModel::AttributeEntry globalListEntry; | |||
|
|
|||
| globalListEntry.readPrivilege = Access::Privilege::kView; | |||
There was a problem hiding this comment.
Might be worth documenting that this is per-spec, and if this changes (e.g. a new global attribute with different access is added) we need to update this code?
bzbarsky-apple
approved these changes
Feb 11, 2025
Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a split of "list attributes not reported" is an ember implementation detail. If we allow full list return, we could use optimizations for having the entire list in flash and not consume RAM to build the list.
Previous API guidance of
MUST include these 2 global attributes and MUST NOT include these 3 global attributesseemed leaky in terms of implementation details. Requiring all allows us better paths to choose optimizations (pure flash const list, vs in-ram building).Moved the "add global list attributes" logic to the codegen implementation rather than it being part of global attribute handling.
Testing
Unit tests updated and pass.