test: Close commissioner session to properly cleanup resources #37522
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
Add explicit CloseSession calls in TC_CGEN_2_8 and TC_CGEN_2_9 to ensure proper cleanup of commissioner library resources. This fixes an issue where subsequent commissioner sessions could not be established due to lingering resources from previous test runs. Bug: Commissioner session establishment failures in subsequent test runs Fix: Add explicit session cleanup after commissioning operations Testing: - Set PICS_USER_PROMPT=1 for manual intervention testing - Verified with terms-and-conditions-app test harness - Confirmed proper cleanup by: 1. Running initial commissioning 2. Performing factory reset (process kill + KVS cleanup) 3. Successfully re-establishing commissioner session - Test passes with manual intervention at factory reset and commissioning prompts
swan-amazon
force-pushed
the
fix/37490
branch
from
8032092 to
c1e9959
Compare
|
PR #37522: Size comparison from 9c8cb33 to c1e9959 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yunhanw-google
approved these changes
Feb 11, 2025
|
PR #37522: Size comparison from e5a49c8 to 4f540b8 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37490
Add explicit CloseSession calls in TC_CGEN_2_8 and TC_CGEN_2_9 to ensure proper cleanup of commissioner library resources. This fixes an issue where subsequent commissioner sessions could not be established due to lingering resources from previous test runs.
Bug: Commissioner session establishment failures in subsequent test runs
Fix: Add explicit session cleanup after commissioning operations
Testing:
Testing Details
Environment Setup
PICS_USER_PROMPT=1to enable interactive command-line prompts during test executionTest Execution Steps
Initial DUT Launch:
rm /tmp/chip* ./out/linux-x64-terms-and-conditions/chip-terms-and-conditions-app \ --version 0 \ --custom-flow 2 \ --capabilities 6 \ --discriminator 3840 \ --passcode 20202021 \ --KVS /tmp/chip_kvs.bin \ --trace_file /tmp/chip_trace.log \ --trace_log 1 \ --trace_decode 1 \ --vendor-id 0xfff1 \ --product-id 0x8012Test Script Execution
python3 src/python_testing/TC_CGEN_2_8.py \ --storage-path admin_storage.json \ --int-arg PIXIT.CGEN.FailsafeExpiryLengthSeconds:900 \ PIXIT.CGEN.RequiredTCAcknowledgements:1 \ PIXIT.CGEN.TCRevision:1 \ --qr-code MT:-24J08M.00KA0648G00 \ --PICS src/app/tests/suites/certification/ci-pics-values \ --in-test-commissioning-method on-networkFactory Reset Simulation:
Results