-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adicionado suporte ao r2 #1151
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,13 +11,14 @@ | |
"@octokit/core": "^3.6.0", | ||
"esbuild": "^0.15.15", | ||
"husky": "^7.0.4", | ||
"lodash": "https://github.com/lodash/lodash.git#npm", | ||
"prettier": "^2.8.3", | ||
"pretty-quick": "^3.1.3", | ||
"rollup": "^2.77.2", | ||
"rollup-plugin-dts": "^4.2.2", | ||
"rollup-plugin-esbuild": "^4.10.2", | ||
"turbo": "^1.11.3", | ||
"lodash": "https://github.com/lodash/lodash.git#npm" | ||
"wrangler": "^3.55.0" | ||
}, | ||
"scripts": { | ||
"preinstall": "npx only-allow pnpm", | ||
|
@@ -44,5 +45,8 @@ | |
"pre-commit": "npx run format:staged" | ||
} | ||
}, | ||
"dependencies": {} | ||
"dependencies": { | ||
"@aws-sdk/client-s3": "^3.574.0", | ||
"aws-sdk": "^2.1618.0" | ||
} | ||
} | ||
Comment on lines
+48
to
52
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please install these the correct package.json file. We are using turborepo, so you can install these deps in the game package like this
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should not be in the config. We should get these from Convars not exposed to client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok