feat: property for custom margin color of TJvPrvwDoc #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obones
requested changes
Jan 31, 2025
jvcl/run/JvPrvwDoc.pas
Outdated
| @@ -216,6 +217,7 @@ TJvPreviewPageOptions = class(TPersistent) | |||
| property Cols: Cardinal read GetCols write SetCols default 1; | |||
| property DrawMargins: Boolean read FDrawMargins write SetDrawMargins default True; | |||
| property HorzSpacing: Cardinal read GetHorzSpacing write SetHorzSpacing default 8; | |||
| property MarginColor: TColor read FMarginColor write FMarginColor default clDkGray; | |||
There was a problem hiding this comment.
You are indicating a default value for FMarginColor here but you are not setting the value for it inside the constructor, which means it will default to 0 aka clBlack
There was a problem hiding this comment.
FMarginColor is now set in the constructor of TJvPreviewPageOptions. In addition, the default color is now clGray which is the same as clDkGray (in Delphi 12).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The color of the margin around the printable range on the page becomes invisible if it is set to a fixed color when a dark theme is used while the page background is white. I thus made it customizable by means of its own property.