Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of exported symbols from the native lookup library #4799

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

andrisaar
Copy link
Collaborator

This ensures that the .so only has two global symbols that it exports: oak_main and register_globals, both following the C calling convention. These are the only symbols that we expect external code to call.

Without this change we have 811 exported symbols:

$ nm bazel-bin/cc/native_sdk/libkey_value_lookup.so | grep " T " | wc -l
811

After that, it's down to the two we'd expect:

$ nm bazel-bin/cc/native_sdk/libkey_value_lookup.so | grep " T "
0000000000009f1f T oak_main
000000000000a9e6 T register_callbacks

@andrisaar andrisaar merged commit 3a0d97e into project-oak:main Feb 14, 2024
17 checks passed
@andrisaar andrisaar deleted the onion branch February 14, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants