Update the SNP predicted measurement tool #4803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradgrobler
force-pushed
the
stage0-predict
branch
from
0d46f1a
to
51fc6c6
Compare
conradgrobler
force-pushed
the
stage0-predict
branch
from
51fc6c6
to
df11775
Compare
thmsbinder
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SNP measurement prediction tool is outdated, since we no-longer preload the kernel into memory before boot. We also have more unmeasured pages configured and need to support additional vCPUs at startup.
With these updates the tool once again predicts that correct measurement in the AMD SEV-SNP attestation report.
Exmaple hex representation of an attestation report running with 2 vCPUs on AMD SEV-SNP:
The measurement starts with the first non-zero bytes on line 4.
Example output from running
cargo run --package=snp_measurement -- --vcpu-count=2with the same Stage 0 binary: