Add generating CWT for tests #4820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradgrobler
approved these changes
Feb 21, 2024
| enum Parameter : int { | ||
| // COSE Key Common parameters. | ||
| // <https://datatracker.ietf.org/doc/html/rfc8152#section-7.1> | ||
| enum CoseKeyCommonParameter : int { |
There was a problem hiding this comment.
partially pre-existing, but I think that in general using enum class is preferred. See https://abseil.io/tips/86
There was a problem hiding this comment.
I'm going to refactor this library as part of #4818
And will implement enum classes
thmsbinder
approved these changes
Feb 21, 2024
| auto serialized_cwt_string = std::string(serialized_cwt->begin(), serialized_cwt->end()); | ||
|
|
||
| auto deserialized_cwt = Cwt::Deserialize(serialized_cwt_string); | ||
| EXPECT_TRUE(deserialized_cwt.ok()) << deserialized_cwt.status(); |
There was a problem hiding this comment.
EXPECT_OK(serialized_cwt)
EXPECT_OK(deserialized_cwt)
I think this will print the status on failure.
There was a problem hiding this comment.
Looks like EXPECT_OK is not available externally:
cc/utils/cose/cwt_test.cc:72:3: error: 'EXPECT_OK' was not declared in this scope; did you mean 'EXPECT_EQ'?
72 | EXPECT_OK(serialized_cwt) << serialized_cwt.status();
| ^~~~~~~~~
| EXPECT_EQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functions to generate COSE_Sign1, COSE_Key and CWT certificates for testing purposes.
These functions are currently not fully implemented and only provide serializing an HPKE public key.
Ref #3641
Ref #4074
Ref #4627