Build the insecure flavour of Oak Functions container #5006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsbinder
approved these changes
Apr 8, 2024
tiziano88
approved these changes
Apr 8, 2024
| ] | ||
| # Feature allow_sensitive_logging is not actually used in the code. It is only used as a | ||
| # required feature to differentiate between the two binaries. | ||
| allow_sensitive_logging = [] |
There was a problem hiding this comment.
I am pretty sure this will bite us back at some point, since features are supposed to be allowed to co-exist (see https://doc.rust-lang.org/cargo/reference/features.html#mutually-exclusive-features ).
Instead personally I would suggest creating two main.rs files (one per binary) and propagating a const / generic / something all the way down from there.
There was a problem hiding this comment.
I'll leave the cleanup to follow-up PRs :)
That'd apply to the Restricted Kernel version as well.
conradgrobler
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to what we have with the Restricted Kernel version, except a little bit more complicated as we need a whole second container.
(I considered bundling both binaries into one container, but decided against it as we want the choice be explicit.)
Ref b/331866772