Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move to core+alloc #189

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Conversation

daviddrysdale
Copy link
Collaborator

Fixes #7

@daviddrysdale
Copy link
Collaborator Author

daviddrysdale commented Jul 19, 2021

This currently still pulls in std because:

The "json" feature requires the base64 and serde dependencies to have
their "alloc" feature enabled.
Requires use of `rand::OsRng` (and with it the `getrandom` feature of
the `rand` crate) rather than `rand::thread_rng()`.
This means that there are no details in errors, so remove the test for
specific error text.
Move to use the same features of dependencies as the crates under test.
This requires a shift from rand::thread_rng() to rand::rngs::OsRng.

This crate still uses `std` though.
This commit cannot be included in a release, because it makes the codebase
rely on an unreleased crate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support no_std in (most) crates
1 participant