Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Improve the code to better match Golang style & lints #219

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Improve the code to better match Golang style & lints #219

merged 2 commits into from
Jan 31, 2023

Conversation

rbehjati
Copy link
Contributor

@rbehjati rbehjati commented Jan 27, 2023 •
edited
Loading

Ref #187

Additional changes were made to the verifier to reduce cyclomatic complexity.

mariaschett
mariaschett approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@mariaschett mariaschett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

nit: the PR does more than updating the function names, so you could reflect that in the title. However, you specify in the conversation and the tests pass :)

@rbehjati rbehjati changed the title Update function names to better match Golang style Improve the code to better match Golang style & lints Jan 31, 2023
@rbehjati
Copy link
Contributor Author

LGTM.

nit: the PR does more than updating the function names, so you could reflect that in the title. However, you specify in the conversation and the tests pass :)

Thanks for the review. Updated the title to better reflect the changes.

@rbehjati rbehjati merged commit b84a1ea into project-oak:main Jan 31, 2023
@rbehjati rbehjati deleted the provenanceIR branch January 31, 2023 12:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mariaschett mariaschett mariaschett approved these changes

@tiziano88 tiziano88 Awaiting requested review from tiziano88

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbehjati @mariaschett