-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
b9b1026
to
a8faf69
Compare
a8faf69
to
b4a790c
Compare
This looks OK. I am wondering if after this change the Probably, the We could just deprecate the current slow |
Perhaps With this change, it may seem like To be more accurate, it might be better to also change |
6ff98e8
to
d27bf03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! :)
return fmt.Errorf("incorrect BuildType: got %s, want %v", provenance.Predicate.BuildType, common.AmberBuildTypeV1) | ||
} | ||
|
||
// TODO(#69): Check metadata against the expected values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we want to indicate the todo also in the documentation of the func?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Done.
d27bf03
to
d75b0fc
Compare
This is PR adds the skeleton for a metadata verifier for Amber provenances (
AmberProvenanceMetadataVerifier
) and calls it inProvenanceBuildWrapper
. This does not give a complete implementation for a metadata verifier, and is mainly intended to solve the problem of slow builds.I have added a few TODO to identify the remaining work. In particular, we have to decide which fields need to be verified in the metadata verifier. The expected values should then be provided as input both to the
verify
command line tool, and toProvenanceBuildWrapper
, as well as the choice of the verifier (see #69).