Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

updated for PHP warnings (ln 465) and missing js #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

updated for PHP warnings (ln 465) and missing js #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kickstart.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ function enqueue_js() {

global $post;

$js = ( WP_DEBUG ) ? 'js/js.dev.js' : 'js/js.js';
$js = ( WP_DEBUG ) ? 'js/js.dev.js' : 'js/js.dev.js';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ideal approach here would be to minify the javascript, if possible, using something like uglify js.

wp_enqueue_script( 'kickstart', plugins_url( $js, __FILE__ ), array( 'jquery' ), $this->version, true );

$l10n = array(
Expand Down Expand Up @@ -462,7 +462,7 @@ function request_filter( $request ) {
*/
function calculate_score_on_save( $post ) {

if ( wp_is_post_revision() || wp_is_post_autosave() )
if ( wp_is_post_revision($post) || wp_is_post_autosave($post) )
return;

if ( get_post_type( $post ) != $this->cpt )
Expand Down