Skip to content
This repository was archived by the owner on Jan 19, 2018. It is now read-only.

[ROUGH DRAFT] Reorganize docs into a single folder and clean up spec description #209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Jun 1, 2016

This is roughly what I would vision it to be. I've copied-pasted the doc that I did with nulecule.md on the atomicapp repo. There's a few things missing (for example, spec we say we can use ftp://, https://, etc. as source, but right now we use docker://) that I still need to add. But I just want people's input first on this before I proceed.

Feel free to have a look at it and let me know what you think.

Fixes #208

Feel free to view it at my branch if you wish: https://github.com/cdrage/nulecule/tree/update-docs

or the https://github.com/cdrage/nulecule/blob/update-docs/SPECIFICATION.md too.

@cdrage
Copy link
Member Author

cdrage commented Jun 1, 2016

Would possibly help with #202 and #113 to make maintainability a lot easier.

@cdrage
Copy link
Member Author

cdrage commented Jun 6, 2016

@goern do you agree that this is cleaner / better for easy-of-entry to Nulecule?

@cdrage
Copy link
Member Author

cdrage commented Jun 7, 2016

@goern @dustymabe @rtnpro @kadel

Could I get some feedback :)

@cdrage
Copy link
Member Author

cdrage commented Jun 15, 2016

ping @goern @dustymabe @rtnpro @kadel

appversion | `string` | **Optional.** The semantic version string of the Container Application.
description | `string` | **Optional.** A human readable description of the Container Application. This may contain information for the deployer of the containerapp.
license | `License Object`| **Optional.** The license information for the containerapp.
arbitrary_data | `string` | **Optional.** Arbitrary `key: value` pair(s) of metadata. May contain nested objects.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the ring of it :\

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me neither, but it was copied from the nulecule spec

@rtnpro
Copy link
Contributor

rtnpro commented Jun 21, 2016

@cdrage In general, it looks good. However, I left a few comments in some places :)

@@ -23,6 +23,10 @@ The Nulecule specification enables complex applications to be defined, packaged

**[Glossary of terms](docs/glossary.md)**

## Specification

An actively maintained page on the specifics of the specification can be found at [SPECIFICATION.md](SPECIFICATION.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe s/specifics/details/ "specifics of the specification" sounds funny :)

@dustymabe
Copy link
Contributor

Why did we delete all of the files in the spec/ directory? I've never used them but they look like schema validation files that could be really useful at some point.


**Reference implementation** https://github.com/projectatomic/atomicapp
**Reference implementation:** https://github.com/projectatomic/atomicapp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still would rather not use the words "reference implementation" here. Let's just list Atomic App as an implementation, but not the reference implementation.

@dustymabe
Copy link
Contributor

There are quite a few differences between spec/README.md (from before your commit) and SPECIFICATION.md after your commit. Any justification for all of those changes? Can you break the rename and the changes into separate commits?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants