Fix various bugs #648
Merged
Fix various bugs #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yelinz
force-pushed
the
fix-various
branch
2 times, most recently
from
f73d694 to
391b5cd
Compare
czosel
reviewed
Dec 29, 2023
addon/services/tags.js
Outdated
| @@ -39,7 +39,7 @@ export default class TagsService extends Service { | |||
| const tagId = dasherize(tagInput.trim()); | |||
| const existing = ( | |||
| await this.store.query("tag", { | |||
| filter: { nameExact: tagId }, | |||
| filter: { name: tagId }, | |||
There was a problem hiding this comment.
this doesn't seem to make sense, let's revert it
czosel
reviewed
Dec 29, 2023
czosel
reviewed
Dec 29, 2023
| @@ -2,7 +2,7 @@ import Service from "@ember/service"; | |||
| import { render, click } from "@ember/test-helpers"; | |||
| import { setupRenderingTest } from "dummy/tests/helpers"; | |||
| import { hbs } from "ember-cli-htmlbars"; | |||
| import fileSaver from "file-saver"; | |||
| import * as fileSaver from "file-saver"; | |||
There was a problem hiding this comment.
current test failures on master are from this
|
🎉 This PR is included in version 4.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
istartswith