Skip to content

Commit

Permalink
code review
Browse files Browse the repository at this point in the history 
Signed-off-by: Steve Kriss <[email protected]>
  • Loading branch information
@skriss
skriss committed Jan 14, 2025
1 parent cef7058 commit 57a6c34
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 14 deletions.
9 changes: 4 additions & 5 deletions internal/xds/v3/callbacks.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,8 @@ import (
)

// NewRequestLoggingCallbacks returns an implementation of the Envoy xDS server
// callbacks for use when Contour is run in Envoy xDS server mode to provide
// request detail logging. Currently only the xDS State of the World callback
// OnStreamRequest is implemented.
// callbacks to provide request detail logging. Currently only xDS State of the
// World callbacks are implemented.
func NewRequestLoggingCallbacks(log logrus.FieldLogger) envoy_server_v3.Callbacks {
return &envoy_server_v3.CallbackFuncs{
StreamOpenFunc: func(_ context.Context, streamID int64, typeURL string) error {
Expand Down Expand Up @@ -60,8 +59,8 @@ func logStreamClosedDetails(l logrus.FieldLogger, streamID int64, node *envoy_co
log.Debug("stream closed")
}

// Helper function for use in the Envoy xDS server callbacks and the Contour
// xDS server to log request details.
// Helper function for use in the Envoy xDS server callbacks to
// log request details.
func logDiscoveryRequestDetails(l logrus.FieldLogger, req *envoy_service_discovery_v3.DiscoveryRequest) {
log := l.WithField("version_info", req.VersionInfo).WithField("response_nonce", req.ResponseNonce)
if req.Node != nil {
Expand Down
9 changes: 0 additions & 9 deletions site/content/docs/main/configuration.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ Where Contour settings can also be specified with command-line flags, the comman
| cluster | ClusterConfig | | The [cluster configuration](#cluster-configuration). |
| network | NetworkConfig | | The [network configuration](#network-configuration). |
| listener | ListenerConfig | | The [listener configuration](#listener-configuration). |
| server | ServerConfig | | The [server configuration](#server-configuration) for `contour serve` command. |
| gateway | GatewayConfig | | The [gateway-api Gateway configuration](#gateway-configuration). |
| rateLimitService | RateLimitServiceConfig | | The [rate limit service configuration](#rate-limit-service-configuration). |
| enableExternalNameService | boolean | `false` | Enable ExternalName Service processing. Enabling this has security implications. Please see the [advisory](https://github.com/projectcontour/contour/security/advisories/GHSA-5ph6-qq5x-7jwc) for more details. |
Expand Down Expand Up @@ -200,14 +199,6 @@ The listener configuration block can be used to configure various parameters for

_This is Envoy's default setting value and is not explicitly configured by Contour._

### Server Configuration

The server configuration block can be used to configure various settings for the `contour serve` command.

| Field Name | Type | Default | Description |
| --------------- | ------ | ------- | ----------------------------------------------------------------------------- |
| | | | |

### Gateway Configuration

The gateway configuration block is used to configure which gateway-api Gateway Contour should configure:
Expand Down

0 comments on commit 57a6c34

Please sign in to comment.