expose runner #450
Closed
expose runner #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogancanbakir
requested review from
ehsandeep
and removed request for
Mzack9999
There was a problem hiding this comment.
@dogancanbakir , i think we already have a library version of dnsx available in libs/ . while exposing runner is simple i think in long run it will cause issues since there are lot of options in runner that are not meant to be used or available in SDK (ex: resume) etc .
if required i think we can just improve existing libs package and make it something similar to nuclei v3 sdk which also includes version check projectdiscovery/nuclei#4104
what do you think ?? cc: @Mzack9999 @ehsandeep
|
@tarunKoyalwar, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the runner and includes an example of its usage -similar to
httpx. Closes #351.