Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #75

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oddlittlebird
Copy link

Minor edits and a bunch of comments for the README. Documentation fixes are a great way for new contributors to participate and learn about a project, so you want it to be as friendly as possible.

TL;DR - You guys are missing a lot of information. I recommend:

  • Create a CONTRIBUTING file and link it from the README. This file should include any guidance for actually writing the docs, including links to a style guide if you have one.
  • The first set of numbered steps is for running Mintlify and building the docs locally, not how to actually write docs.
  • Information is missing, like, will Mintlify automatically open in development mode? Do I need to do something to trigger a fresh build? What else does someone new to this project need to know?
  • I see a bunch of manual building tasks that are done locally in the Deployment section.
    • Why are these not done automatically with GitHub actions or on a server?
    • Is the user supposed to upload changed files to Git and merge them after they are built? You do not actually specify.

Copy link
Author

@oddlittlebird oddlittlebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments and questions.

@@ -1,7 +1,7 @@
# ProjectDiscovery Documentation

<h4 align="center">
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This combination of markdown and HTML is really weird. I suggest just using markdown.

@@ -19,26 +19,24 @@

---

## Development
## Build docs locally
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should have a separate section or separate topic with guidance for actually working on these docs.

1. Install mintlify with `npm i -g mintlify@latest`
1. Run `mintlify dev`
1. Fork this repository.
1. Install mintlify with `npm i -g mintlify@latest`.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm should be listed in a Prerequisites section, along with installing mintlify.

Also, does the user ever need to update Mintlify?

1. Run `mintlify dev`
1. Fork this repository.
1. Install mintlify with `npm i -g mintlify@latest`.
1. Run `mintlify dev`.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do they run this? Root level of docs folder, I assume? Also, where will the docs build show up? Does it go to a default port in their default browser? What should they expect?

1. Run `mintlify dev`
1. Fork this repository.
1. Install mintlify with `npm i -g mintlify@latest`.
1. Run `mintlify dev`.

## Deploying
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear what you are deploying. Do you mean "Deploy updated files"? "Deploy new documentation"? And where is it getting deployed?

And when all this is done, how do you get files from your local fork back to the main project? (Assume you are talking to a technical writer who wants to get some practice in open source. This is super common.)


1. Build the JS Protocol Docs
1. Build the JS Protocol Docs:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean JavaScript? If so, spell it out on the first use.


1. Build the JS Protocol Docs
1. Build the JS Protocol Docs:

- `npm install -g jsdoc-to-markdown`
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, where do you run this? And do they have to be separate commands, or can you run them together? If you can run them together, then why aren't they in a code block?


- `npm install -g jsdoc-to-markdown`
- `./bin/jsdocs.sh`

2. Build the PDCP API reference documentation
2. Build the PDCP API reference documentation:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember, whoever is running this might be new to the project. Tell them what PDCP API documentation is, preferably in the section about actually working on docs, which does not yet exist.


- `npm install -g jsdoc-to-markdown`
- `./bin/jsdocs.sh`

2. Build the PDCP API reference documentation
2. Build the PDCP API reference documentation:

- Either download the latest `openapi.yaml` manually or run `./bin/download-api.sh`
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Download from where? And couldn't this be automated in a makefile or something?

3. Mintlify handles the deployment automatically.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a user, this does not tell me how I know if the deployment is successful, or what to do if I don't see updated files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant