Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add version bump steps #232

Merged
merged 5 commits into from
Sep 20, 2023
Merged

add version bump steps #232

merged 5 commits into from
Sep 20, 2023

Conversation

dogancanbakir
Copy link
Member

Closes #231.

@dogancanbakir dogancanbakir self-assigned this Sep 20, 2023
ehsandeep
ehsandeep reviewed Sep 20, 2023
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add the version bump step after Get commit count step, so we can run this step only when the below condition is true.

        if: ${{ steps.get_commit.outputs.COMMIT_COUNT > 0  }}

@dogancanbakir
Copy link
Member Author

Depends on projectdiscovery/utils#258

@ehsandeep ehsandeep merged commit 9f18397 into main Sep 20, 2023
2 checks passed
@ehsandeep ehsandeep deleted the add_version_bump_steps branch September 20, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increment project version before tag creation
2 participants
@dogancanbakir @ehsandeep