Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable cookie reuse / data sharing as default in template / workflows #3894

Closed
ehsandeep opened this issue Jun 30, 2023 · 0 comments · Fixed by #4292
Closed

enable cookie reuse / data sharing as default in template / workflows #3894

ehsandeep opened this issue Jun 30, 2023 · 0 comments · Fixed by #4292
Assignees
Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes. workflows feature / bug related to workflows

Comments

@ehsandeep
Copy link
Member

Please describe your feature request:

With the addition of #2576, it made it possible to share data between templates when using with workflows, enabled writing workflows that require authentication before running templates, since it's commonly required behavior it would be much more useful to enable it as default and optionally disable it when required, which will unblock template authors of the need of explicitly adding cookie-reuse in each template that needs to be used within workflows.

Template attribute to disable this specific behavior:

disable-cookie: true

Describe the use case of this feature:

Write authenticated workflows with ease without manually updating each underlying template with cookie-reuse: true

id: test-workflow

info:
  name: Test Workflow
  author: pdteam

workflows:
  - template: http/default-login/xxx.yaml
    subtemplates:
      - template: http/x/template1.yaml
      - template: http/x/template2.yaml

Note:

  • cookie-reuse can be marked as deprecated and to be removed later.
@ehsandeep ehsandeep added Type: Enhancement Most issues will probably ask for additions or changes. workflows feature / bug related to workflows labels Jun 30, 2023
@ehsandeep ehsandeep added the Priority: High After critical issues are fixed, these should be dealt with before any further issues. label Aug 25, 2023
@dogancanbakir dogancanbakir self-assigned this Oct 25, 2023
@tarunKoyalwar tarunKoyalwar linked a pull request Oct 27, 2023 that will close this issue
4 tasks
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes. workflows feature / bug related to workflows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants