Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce disable-cookie #4292

Merged
merged 6 commits into from
Nov 18, 2023
Merged

introduce disable-cookie #4292

merged 6 commits into from
Nov 18, 2023

Conversation

dogancanbakir
Copy link
Member

@dogancanbakir dogancanbakir commented Oct 25, 2023

Proposal

With the addition of #2576, it made it possible to share data between templates when using with workflows, enabled writing workflows that require authentication before running templates, since it's commonly required behavior it would be much more useful to enable it as default and optionally disable it when required, which will unblock template authors of the need of explicitly adding cookie-reuse in each template that needs to be used within workflows.

Template attribute to disable this specific behavior:

disable-cookie: true

Describe the use case of this feature:

Write authenticated workflows with ease without manually updating each underlying template with cookie-reuse: true

id: test-workflow

info:
  name: Test Workflow
  author: pdteam

workflows:
  - template: http/default-login/xxx.yaml
    subtemplates:
      - template: http/x/template1.yaml
      - template: http/x/template2.yaml

Note:

  • cookie-reuse can be marked as deprecated and to be removed later.

Closes #3894

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation lgtm !

failing integration test

Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehsandeep ehsandeep merged commit a9efb75 into dev Nov 18, 2023
12 checks passed
@ehsandeep ehsandeep deleted the introduce_disable_cookie branch November 18, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable cookie reuse / data sharing as default in template / workflows
3 participants