-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reducing data race via SyncLockMap #3959
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggesting removing unused types,methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
integration tests are failing due to expired client / server certificates that are used in integration test generic/auth/certifiicate/http-get.yaml
$ TESTS="generic/auth/certificate/http-get.yaml" ./run.sh 130 ↵
::group::Build nuclei
::endgroup::
::group::Build nuclei integration-test
::endgroup::
::group::Installing nuclei templates
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ v2.9.9
projectdiscovery.io
[INF] No new updates found for nuclei templates
::endgroup::
2023/07/24 20:04:46 http: TLS handshake error from 127.0.0.1:50778: tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2023-07-24T20:04:46+05:30 is after 2023-07-21T00:43:06Z
2023/07/24 20:04:47 http: TLS handshake error from 127.0.0.1:50779: tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2023-07-24T20:04:47+05:30 is after 2023-07-21T00:43:06Z
[✘] Test "generic/auth/certificate/http-get.yaml" failed: incorrect number of results: 0 (actual) vs [1] (expected)
Results:
cc: @Mzack9999
Proposed changes
This PR replace
contextargs.Args
withmapsutil.SyncLockMap
improving native race avoidanceChecklist