Reducing data race via SyncLockMap #3959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mzack9999
added
the
Type: Bug
Mzack9999
changed the title
tarunKoyalwar
requested changes
Jul 21, 2023
tarunKoyalwar
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
integration tests are failing due to expired client / server certificates that are used in integration test generic/auth/certifiicate/http-get.yaml
$ TESTS="generic/auth/certificate/http-get.yaml" ./run.sh 130 ↵
::group::Build nuclei
::endgroup::
::group::Build nuclei integration-test
::endgroup::
::group::Installing nuclei templates
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ v2.9.9
projectdiscovery.io
[INF] No new updates found for nuclei templates
::endgroup::
2023/07/24 20:04:46 http: TLS handshake error from 127.0.0.1:50778: tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2023-07-24T20:04:46+05:30 is after 2023-07-21T00:43:06Z
2023/07/24 20:04:47 http: TLS handshake error from 127.0.0.1:50779: tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2023-07-24T20:04:47+05:30 is after 2023-07-21T00:43:06Z
[✘] Test "generic/auth/certificate/http-get.yaml" failed: incorrect number of results: 0 (actual) vs [1] (expected)
Results:
cc: @Mzack9999
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR replace
contextargs.Argswithmapsutil.SyncLockMapimproving native race avoidanceChecklist