-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omit Empty Fields #3977
Merged
ehsandeep
merged 6 commits into
projectdiscovery:dev
from
kchason:3892-omit-empty-fields
Jul 28, 2023
Merged
Omit Empty Fields #3977
ehsandeep
merged 6 commits into
projectdiscovery:dev
from
kchason:3892-omit-empty-fields
Jul 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsandeep
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo https://projectdiscovery.io | ./nuclei -id tech-detect -j -or | jq .
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ v2.9.9
projectdiscovery.io
[INF] Current nuclei version: v2.9.9 (latest)
[INF] Current nuclei-templates version: v9.5.8 (latest)
[INF] New templates added in latest release: 113
[INF] Templates loaded for current scan: 1
[INF] Targets loaded for current scan: 1
{
"template": "http/technologies/tech-detect.yaml",
"template-url": "https://github.com/projectdiscovery/nuclei-templates/blob/main/http/technologies/tech-detect.yaml",
"template-id": "tech-detect",
"template-path": "/Users/geekboy/nuclei-templates/http/technologies/tech-detect.yaml",
"info": {
"name": "Wappalyzer Technology Detection",
"author": [
"hakluke"
],
"tags": [
"tech"
],
"severity": "info",
"metadata": {
"max-request": 1
}
},
"matcher-name": "google-font-api",
"type": "http",
"host": "https://projectdiscovery.io",
"matched-at": "https://projectdiscovery.io",
"ip": "172.67.74.214",
"timestamp": "2023-07-26T00:00:52.380353+05:30",
"curl-command": "curl -X 'GET' -d '' -H 'Accept: */*' -H 'Accept-Language: en' -H 'User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686 on x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2820.59 Safari/537.36' 'https://projectdiscovery.io'",
"matcher-status": true
}
ehsandeep
added
the
Type: Maintenance
Updating phrasing or wording to make things clearer or removing ambiguity.
label
Jul 25, 2023
tarunKoyalwar
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ echo https://projectdiscovery.io | ./nuclei -id tech-detect -j -or | jq .
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ v2.9.9
projectdiscovery.io
[INF] Current nuclei version: v2.9.9 (latest)
[INF] Current nuclei-templates version: v9.5.8 (latest)
[INF] New templates added in latest release: 113
[INF] Templates loaded for current scan: 1
[INF] Targets loaded for current scan: 1
{
"template": "http/technologies/tech-detect.yaml",
"template-url": "https://github.com/projectdiscovery/nuclei-templates/blob/main/http/technologies/tech-detect.yaml",
"template-id": "tech-detect",
"template-path": "/Users/tarun/nuclei-templates/http/technologies/tech-detect.yaml",
"info": {
"name": "Wappalyzer Technology Detection",
"author": [
"hakluke"
],
"tags": [
"tech"
],
"severity": "info",
"metadata": {
"max-request": 1
}
},
"matcher-name": "google-font-api",
"type": "http",
"host": "https://projectdiscovery.io",
"matched-at": "https://projectdiscovery.io",
"ip": "104.26.6.152",
"timestamp": "2023-07-28T19:31:51.783437+05:30",
"curl-command": "curl -X 'GET' -d '' -H 'Accept: */*' -H 'Accept-Language: en' -H 'User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36' 'https://projectdiscovery.io'",
"matcher-status": true
}
{
"template": "http/technologies/tech-detect.yaml",
"template-url": "https://github.com/projectdiscovery/nuclei-templates/blob/main/http/technologies/tech-detect.yaml",
"template-id": "tech-detect",
"template-path": "/Users/tarun/nuclei-templates/http/technologies/tech-detect.yaml",
"info": {
"name": "Wappalyzer Technology Detection",
"author": [
"hakluke"
],
"tags": [
"tech"
],
"severity": "info",
"metadata": {
"max-request": 1
}
},
"matcher-name": "cloudflare",
"type": "http",
"host": "https://projectdiscovery.io",
"matched-at": "https://projectdiscovery.io",
"ip": "104.26.6.152",
"timestamp": "2023-07-28T19:31:51.783831+05:30",
"curl-command": "curl -X 'GET' -d '' -H 'Accept: */*' -H 'Accept-Language: en' -H 'User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36' 'https://projectdiscovery.io'",
"matcher-status": true
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Addresses #3892.
omitempty
property to theLines
propertyreference
field to a pointer to aRawStringSlice
since structs themselves (e.g.RawStringSlice
) don't properly followomitempty
marshaling since they aren't nilableChecklist