Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read-only filesystem fixes for when ~/.config is not writable #3990

Closed
wants to merge 2 commits into from

Conversation

S4lt5
Copy link

@S4lt5 S4lt5 commented Jul 27, 2023

Proposed changes

When running nuclei in a lambda function, I ran into the issues described in #3576.

I've been using the changes locally for a few months with great success, but I understand that this might break existing installs so I am not sure if this is something that will even be considered.

I know there is a bit of testing and etc to sort out, but as I have not done any nuclei PRs out side of the templates project, I figured the best course of action was just to start a PR and get a dialog going.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@tarunKoyalwar tarunKoyalwar self-requested a review July 28, 2023 13:51
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yablargo thanks for PR , we are in middle of adding this support across all projectdiscovery tools see: projectdiscovery/goflags#114 . its currently in functional testing phase ( it will migrate all existing configs from old directory to new one ) . we will roll out this in nuclei and other tools soon after more testing .

Thanks , meanwhile you can try projectdiscovery/goflags#114 and share if you face any issues

@tarunKoyalwar tarunKoyalwar added the Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. label Jul 28, 2023
@tarunKoyalwar tarunKoyalwar deleted the branch projectdiscovery:dev August 4, 2023 14:51
@tarunKoyalwar tarunKoyalwar reopened this Aug 4, 2023
@tarunKoyalwar
Copy link
Member

closing this as the issue was resolved in #4228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Revision Needed Submitter of PR needs to revise the PR related to the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants