Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edge cases disable-path-automerge #4035

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Conversation

RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented Aug 8, 2023

Proposed changes

#3475 (comment)
^ in case 3: disable-path-automerge is not working

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@RamanaReddy0M
Copy link
Contributor Author

✗ cat test.yaml 
id: dpa-edge-case

info:
  name: Disable Path Automerge 
  author: PD
  severity: info

http:
  - raw:
      - |
        GET  HTTP/1.1
        Host: {{Hostname}}
        Content-Type: application/json
    disable-path-automerge: true
  
    matchers:
      - type: status
        status:
          - 200
   
✗ go run . -u example.com -t test.yaml -dreq

                     __     _
   ____  __  _______/ /__  (_)
  / __ \/ / / / ___/ / _ \/ /
 / / / / /_/ / /__/ /  __/ /
/_/ /_/\__,_/\___/_/\___/_/   v2.9.10

                projectdiscovery.io

[INF] Current nuclei version: v2.9.10 (latest)
[INF] Current nuclei-templates version: v9.6.0 (latest)
[INF] New templates added in latest release: 33
[INF] Templates loaded for current scan: 1
[INF] Targets loaded for current scan: 1
[INF] Running httpx on input host
[INF] Found 1 URL from httpx
[INF] [dpa-edge-case] Dumped HTTP request for https://example.com

GET / HTTP/1.1
Host: example.com
User-Agent: Mozilla/5.0 (Windows NT 4.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/37.0.2049.0 Safari/537.36
Connection: close
Content-Type: application/json
Accept-Encoding: gzip

[dpa-edge-case] [http] [info] https://example.com

Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@ehsandeep ehsandeep merged commit 7997e8d into dev Aug 10, 2023
11 checks passed
@ehsandeep ehsandeep deleted the isssue-3475-dpa-edge-case branch August 10, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird behaviour when handling paths in rawhttp defined requests
3 participants