Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use default perms #4039

Merged
merged 4 commits into from
Aug 11, 2023
Merged

use default perms #4039

merged 4 commits into from
Aug 11, 2023

Conversation

dogancanbakir
Copy link
Member

Proposed changes

This PR fixes improper permission usage on file operations. Closes #3979.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@dogancanbakir dogancanbakir self-assigned this Aug 10, 2023
@dogancanbakir dogancanbakir linked an issue Aug 10, 2023 that may be closed by this pull request
Config and resume file created with executable permission #3979
Closed
Mzack9999
Mzack9999 approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

$ ./nuclei
...
$ stat -f %A ~/.config/nuclei/config.yaml
600
$

@Mzack9999 Mzack9999 added the Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. label Aug 11, 2023
@ehsandeep ehsandeep merged commit deb351c into dev Aug 11, 2023
11 checks passed
@ehsandeep ehsandeep deleted the use_default_perms branch August 11, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels
Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config and resume file created with executable permission
3 participants
@dogancanbakir @ehsandeep @Mzack9999