Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pkg import only once #4230

Closed
wants to merge 0 commits into from
Closed

chore: pkg import only once #4230

wants to merge 0 commits into from

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Oct 10, 2023 •
edited by dogancanbakir
Loading

Proposed changes

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ehsandeep ehsandeep changed the base branch from main to dev October 10, 2023 08:24
@ehsandeep ehsandeep changed the base branch from dev to main October 10, 2023 08:25
dogancanbakir
dogancanbakir approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@dogancanbakir dogancanbakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehsandeep ehsandeep changed the base branch from main to dev October 19, 2023 13:56
ehsandeep
ehsandeep requested changes Nov 14, 2023
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflict

@testwill testwill closed this Nov 15, 2023
@dogancanbakir
Copy link
Member

The issue seems to have been resolved in the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep requested changes

@dogancanbakir dogancanbakir dogancanbakir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@testwill @dogancanbakir @ehsandeep