Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing internal resolver override #5035

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Fixing internal resolver override #5035

merged 2 commits into from
Apr 15, 2024

Conversation

Mzack9999
Copy link
Member

Proposed changes

Fixing internal resolvers override when applied via SDK

Closes #4947

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Apr 11, 2024
@Mzack9999 Mzack9999 self-assigned this Apr 11, 2024
@Mzack9999 Mzack9999 mentioned this pull request Apr 11, 2024
Closed
@Mzack9999 Mzack9999 marked this pull request as ready for review April 11, 2024 22:32
@dogancanbakir
Copy link
Member

test failure due [asnmap-api] missing or invalid api key (get free api & configure it from https://cloud.projectdiscovery.io/?ref=api_key)

@Mzack9999
Copy link
Member Author

merging as test error is unrelated

@Mzack9999 Mzack9999 merged commit d576db3 into dev Apr 15, 2024
9 of 12 checks passed
@Mzack9999 Mzack9999 deleted the bugfix-4947-internal-resolvers branch April 15, 2024 16:02
@BrewTestBot BrewTestBot mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogancanbakir dogancanbakir dogancanbakir approved these changes

@ehsandeep ehsandeep Awaiting requested review from ehsandeep

Assignees

@Mzack9999 Mzack9999

Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use nuclei sdk result dns error "no address found for host"
2 participants
@Mzack9999 @dogancanbakir