Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix go install failing #5083

Merged
merged 6 commits into from
Apr 24, 2024
Merged

fix go install failing #5083

merged 6 commits into from
Apr 24, 2024

Conversation

tarunKoyalwar
Copy link
Member

@tarunKoyalwar tarunKoyalwar commented Apr 23, 2024

Proposed Changes

  • remove fork: use official go-echarts
  • the primary reason we were using go-echarts because at that time there were some bugs and some indentation issues but now those are fixed in go-echarts upstream
  • there is a slight indentation issue ( no space between multiple charts) but that should be ok for now since its meant to for internal purpose
  • closes dev branch: cannot install using go install  #5082

@tarunKoyalwar tarunKoyalwar self-assigned this Apr 23, 2024
@tarunKoyalwar tarunKoyalwar changed the title issue 5082 go install echarts fix fix go install failing Apr 23, 2024
@tarunKoyalwar tarunKoyalwar marked this pull request as ready for review April 23, 2024 13:57
@tarunKoyalwar
Copy link
Member Author

installation using go install works now

$  go install -v github.com/projectdiscovery/nuclei/v3/cmd/nuclei@issue-5082-go-install-echarts-fix
go: downloading github.com/projectdiscovery/nuclei/v3 v3.0.1-0.20240423135359-1641d0abec44
github.com/projectdiscovery/nuclei/v3/pkg/templates/extensions
github.com/projectdiscovery/nuclei/v3/pkg/protocols/common/marker
github.com/projectdiscovery/nuclei/v3/pkg/catalog
github.com/projectdiscovery/nuclei/v3/pkg/input/types
github.com/projectdiscovery/nuclei/v3/pkg/catalog/config
github.com/projectdiscovery/nuclei/v3/pkg/protocols/common/utils/excludematchers
...
github.com/projectdiscovery/nuclei/v3/pkg/protocols/common/automaticscan
github.com/projectdiscovery/nuclei/v3/internal/runner
github.com/projectdiscovery/nuclei/v3/cmd/nuclei

@ehsandeep ehsandeep merged commit 515f7c1 into dev Apr 24, 2024
8 of 12 checks passed
@ehsandeep ehsandeep deleted the issue-5082-go-install-echarts-fix branch April 24, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev branch: cannot install using go install
3 participants