Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: conditionally panic-recover #5553

Merged
merged 3 commits into from
Aug 28, 2024
Merged

feat: conditionally panic-recover #5553

merged 3 commits into from
Aug 28, 2024

Commits on Aug 24, 2024

  1. feat: conditionally panic-recover 

    As discussed with @Mzack9999, we should avoid
overusing panic-recover. We need to review the RCA
first to determine whether this is an exceptional
situation or if it's a higher-level function meant
to recover from a panic. This approach will help
us establish a robust error-handling strategy.

The implementation of panic-recover should be
conditional and NOT applied when running in a CI
environment AND IS temporary. Once we've caught
all errors and made the necessary corrections, we
can remove the deferred recover function.

Signed-off-by: Dwi Siswanto <[email protected]>
    @dwisiswant0
    dwisiswant0 committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    55d78a0 View commit details
    Browse the repository at this point in the history

  2. chore(deps): bump go-ci to v1.0.2 

    Signed-off-by: Dwi Siswanto <[email protected]>
    @dwisiswant0
    dwisiswant0 committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    c6c7d19 View commit details
    Browse the repository at this point in the history

  3. chore(make): add -race to GOFLAGS in test 

    Signed-off-by: Dwi Siswanto <[email protected]>
    @dwisiswant0
    dwisiswant0 committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    b4ac2c8 View commit details
    Browse the repository at this point in the history